vim-patch:9.0.1331: illegal memory access when using :ball in Visual mode (#22343)

Problem:    Illegal memory access when using :ball in Visual mode.
Solution:   Stop Visual mode when using :ball. (Pavel Mayorov, closes vim/vim#11923)

e1121b1394

Co-authored-by: Pavel Mayorov <pmayorov@cloudlinux.com>
This commit is contained in:
zeertzjq 2023-02-20 23:02:05 +08:00 committed by GitHub
parent f1816f9ee2
commit 93c627b90b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 0 deletions

View File

@ -3600,6 +3600,10 @@ void ex_buffer_all(exarg_T *eap)
all = true;
}
// Stop Visual mode, the cursor and "VIsual" may very well be invalid after
// switching to another buffer.
reset_VIsual_and_resel();
setpcmark();
// Close superfluous windows (two windows for the same buffer).

View File

@ -1536,4 +1536,25 @@ func Test_switch_buffer_ends_visual_mode()
exe 'bwipe!' buf2
endfunc
" Check fix for the heap-based buffer overflow bug found in the function
" utfc_ptr2len and reported at
" https://huntr.dev/bounties/ae933869-a1ec-402a-bbea-d51764c6618e
func Test_heap_buffer_overflow()
enew
set updatecount=0
norm R0
split other
norm R000
exe "norm \<C-V>l"
ball
call assert_equal(getpos("."), getpos("v"))
call assert_equal('n', mode())
norm zW
%bwipe!
set updatecount&
endfunc
" vim: shiftwidth=2 sts=2 expandtab