IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

lsp: Fix pumvisible() check introduced in #12900 (#13866)

Browse Source 
`pumvisible()` returns a number, and numbers are always `true` in Lua,
so the return value needs to be checked explicitly.

Using https://github.com/neovim/neovim/pull/12900 as context, it appears
the intention was to move into the `if` branch when the completion popup
is not shown (i.e. `vim.fn.pumvisible() == 0`).
This commit is contained in:
runiq 2021-02-04 12:35:17 +01:00 committed by GitHub
parent b96db38af1
commit 94cf7bba00
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
runtime/lua/vim/lsp/util.lua
View File

@ -726,7 +726,7 @@ function M.focusable_float(unique_name, fn)
local bufnr = api.nvim_get_current_buf() local bufnr = api.nvim_get_current_buf()
do do
local win = find_window_by_var(unique_name, bufnr) local win = find_window_by_var(unique_name, bufnr)
if win and api.nvim_win_is_valid(win) and not vim.fn.pumvisible() then if win and api.nvim_win_is_valid(win) and vim.fn.pumvisible() == 0 then
api.nvim_set_current_win(win) api.nvim_set_current_win(win)
api.nvim_command("stopinsert") api.nvim_command("stopinsert")
return return