IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(lsp): avoid pipe leaks if lsp cmd isn't executable (#19717)

Browse Source 
The `onexit` handler isn't called if `uv.spawn` doesn't return a handle.
This commit is contained in:
Mathias Fußenegger 2022-08-11 17:04:55 +02:00 committed by GitHub
parent 8b67f37798
commit 996fc2256b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
runtime/lua/vim/lsp/rpc.lua
View File

@ -340,6 +340,9 @@ local function start(cmd, cmd_args, dispatchers, extra_spawn_params)
end end
handle, pid = uv.spawn(cmd, spawn_params, onexit) handle, pid = uv.spawn(cmd, spawn_params, onexit)
if handle == nil then if handle == nil then
stdin:close()
stdout:close()
stderr:close()
local msg = string.format('Spawning language server with cmd: `%s` failed', cmd) local msg = string.format('Spawning language server with cmd: `%s` failed', cmd)
if string.match(pid, 'ENOENT') then if string.match(pid, 'ENOENT') then
msg = msg msg = msg