IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.0.0527: long sign text may overflow buffer (#22496)

Browse Source 
Problem:    Long sign text may overflow buffer.
Solution:   Use a larger buffer.  Prevent for overflow.

2b1ddf19f8

Don't change the size of extra[] as it's already large enough.

N/A patches for version.c:

vim-patch:9.0.0523: more compiler warnings for arguments in small version

Co-authored-by: Bram Moolenaar <Bram@vim.org>
This commit is contained in:
zeertzjq 2023-03-03 22:24:12 +08:00 committed by GitHub
parent ef52592cf8
commit a88c18c24e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/nvim/drawline.c
View File

@ -413,13 +413,13 @@ static void get_sign_display_info(bool nrcol, win_T *wp, winlinevars_T *wlv, int
wlv->c_final = NUL; wlv->c_final = NUL;
if (nrcol) { if (nrcol) {
int n, width = number_width(wp) - 2; int width = number_width(wp) - 2;
for (n = 0; n < width; n++) { size_t n;
for (n = 0; (int)n < width; n++) {
wlv->extra[n] = ' '; wlv->extra[n] = ' ';
} }
wlv->extra[n] = NUL; wlv->extra[n] = NUL;
STRCAT(wlv->extra, wlv->p_extra); snprintf(wlv->extra + n, sizeof(wlv->extra) - n, "%s ", wlv->p_extra);
STRCAT(wlv->extra, " ");
wlv->p_extra = wlv->extra; wlv->p_extra = wlv->extra;
wlv->n_extra = (int)strlen(wlv->p_extra); wlv->n_extra = (int)strlen(wlv->p_extra);
} else { } else {

14
src/nvim/testdir/test_signs.vim
View File

@ -196,6 +196,20 @@ func Test_sign()
\ bufnr('%'), 'E155:') \ bufnr('%'), 'E155:')
endfunc endfunc
func Test_sign_many_bytes()
new
set signcolumn=number
set number
call setline(1, 'some text')
" composing characters can use many bytes, check for overflow
sign define manyBytes text=▶᷄᷅᷆◀᷄᷅᷆᷇
sign place 17 line=1 name=manyBytes
redraw
bwipe!
sign undefine manyBytes
endfunc
" Undefining placed sign is not recommended. " Undefining placed sign is not recommended.
" Quoting :help sign " Quoting :help sign
" "