IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:8.1.0334: 'autowrite' takes effect when buffer is not to be written

Browse Source 
Problem:    'autowrite' takes effect when buffer is not to be written.
Solution:   Don't write buffers that are not supposed to be written. (Even Q
            Jones, closes vim/vim#3391)  Add tests for 'autowrite'.
8c9e7b00f6
This commit is contained in:
Jan Edmund Lazo 2018-09-03 21:06:59 -04:00
parent 4d6ba4d06a
commit b6e83ba284
2 changed files with 40 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/ex_cmds2.c
View File

@ -1209,7 +1209,7 @@ int autowrite(buf_T *buf, int forceit)
return r; return r;
} }
/// flush all buffers, except the ones that are readonly /// Flush all buffers, except the ones that are readonly or are never written.
void autowrite_all(void) void autowrite_all(void)
{ {
if (!(p_aw || p_awa) || !p_write) { if (!(p_aw || p_awa) || !p_write) {
@ -1217,7 +1217,7 @@ void autowrite_all(void)
} }
FOR_ALL_BUFFERS(buf) { FOR_ALL_BUFFERS(buf) {
if (bufIsChanged(buf) && !buf->b_p_ro) { if (bufIsChanged(buf) && !buf->b_p_ro && !bt_dontwrite(buf)) {
bufref_T bufref; bufref_T bufref;
set_bufref(&bufref, buf); set_bufref(&bufref, buf);
(void)buf_write_all(buf, false); (void)buf_write_all(buf, false);

38
src/nvim/testdir/test_writefile.vim
View File

@ -75,3 +75,41 @@ func Test_nowrite_quit_split()
endif endif
bwipe Xfile bwipe Xfile
endfunc endfunc
func Test_writefile_autowrite()
set autowrite
new
next Xa Xb Xc
call setline(1, 'aaa')
next
call assert_equal(['aaa'], readfile('Xa'))
call setline(1, 'bbb')
call assert_fails('edit XX')
call assert_false(filereadable('Xb'))
set autowriteall
edit XX
call assert_equal(['bbb'], readfile('Xb'))
bwipe!
call delete('Xa')
call delete('Xb')
set noautowrite
endfunc
func Test_writefile_autowrite_nowrite()
set autowrite
new
next Xa Xb Xc
set buftype=nowrite
call setline(1, 'aaa')
let buf = bufnr('%')
" buffer contents silently lost
edit XX
call assert_false(filereadable('Xa'))
rewind
call assert_equal('', getline(1))
bwipe!
set noautowrite
endfunc