ci: revisit OpenBSD/FreeBSD config (#11477)

.builds/freebsd.yml

@@ -29,12 +29,16 @@ tasks:
 - build: |
     cd neovim
     gmake CMAKE_BUILD_TYPE=Release CMAKE_EXTRA_FLAGS="${CMAKE_EXTRA_FLAGS}" nvim
-- test: |
+- functionaltest: |
     cd neovim
-    gmake unittest functionaltest
+    gmake functionaltest
+- unittest: |
+    cd neovim
+    gmake unittest
 
 # Unfortunately, oldtest is tanking hard on sourcehut's FreeBSD instance
 # and not producing any logs as a result. So don't do this task for now.
+# Ref: https://github.com/neovim/neovim/pull/11477#discussion_r352095005.
 # - test-oldtest: |
 #     cd neovim
 #     gmake oldtest

.builds/openbsd.yml

@@ -16,26 +16,28 @@ packages:
 sources:
 - https://github.com/neovim/neovim
 
+environment:
+  SOURCEHUT: 1
+  LC_CTYPE: en_US.UTF-8
+  CMAKE_EXTRA_FLAGS: -DTRAVIS_CI_BUILD=ON -DMIN_LOG_LEVEL=3
+
 tasks:
-- build: |
+- build-deps: |
     export AUTOCONF_VERSION=2.69
     export AUTOMAKE_VERSION=1.15
-    cd neovim
-    mkdir .deps
-    cd .deps
+    mkdir neovim/.deps
+    cd neovim/.deps
     cmake -G Ninja ../third-party/
     cmake --build . --config Debug
-    cd ..
-    mkdir build
-    cd build
-    cmake -G Ninja -DMIN_LOG_LEVEL=3 ..
+- build: |
+    mkdir neovim/build
+    cd neovim/build
+    cmake -G Ninja $CMAKE_EXTRA_FLAGS ..
     cmake --build . --config Debug
     ./bin/nvim --version
-- test: |
-    export LC_CTYPE=en_US.UTF-8
-    # functional tests
+- functionaltest: |
     cd neovim/build
     cmake --build . --config Debug --target functionaltest
-    # oldtests
-    cd ..
+- oldtest: |
+    cd neovim
     gmake oldtest

src/nvim/tui/terminfo.c

@@ -47,9 +47,8 @@ bool terminfo_is_bsd_console(const char *term)
   // like cursor-shaping. Assume that TERM=xterm is degraded. #8644
   return strequal(term, "xterm") && !!os_getenv("XTERM_VERSION");
 # endif
-#else
-  return false;
 #endif
+  return false;
 }
 
 /// Loads a built-in terminfo db when we (unibilium) failed to load a terminfo