TUI: always use safe cursor movement after resize

The old code could lead to a memory error in the following situation:

0. The previous cursor position was row 50 since before, on a grid
larger than 50 rows.
1. grid_resize changes the grid height to 40, and invalidly assumes the
resize moved the physical cursor to row 0
2. Some event used a operation that could move the cursor (such as clear), and
then reset the cursor to the "true" position row 50 (pointless after #8221, but
I forgot to remove it)
3. raw_line/cheap_to_print is invoked, and tries to inspect the grid at
row 50 (memory error)
4. grid_cursor_goto would have been called at this point, and set a
valid cursor position 0-39.
This commit is contained in:
Björn Linse 2018-10-02 13:46:53 +02:00
parent 39ad99b594
commit cc305213d7
2 changed files with 11 additions and 9 deletions

View File

@ -577,7 +577,7 @@ static void final_column_wrap(UI *ui)
{
TUIData *data = ui->data;
UGrid *grid = &data->grid;
if (grid->col == ui->width) {
if (grid->row != -1 && grid->col == ui->width) {
grid->col = 0;
if (grid->row < MIN(ui->height, grid->height - 1)) {
grid->row++;
@ -647,6 +647,9 @@ static void cursor_goto(UI *ui, int row, int col)
ugrid_goto(grid, row, col);
return;
}
if (grid->row == -1) {
goto safe_move;
}
if (0 == col ? col != grid->col :
row != grid->row ? false :
1 == col ? 2 < grid->col && cheap_to_print(ui, grid->row, 0, col) :
@ -725,6 +728,8 @@ static void cursor_goto(UI *ui, int row, int col)
return;
}
}
safe_move:
unibi_goto(ui, row, col);
ugrid_goto(grid, row, col);
}
@ -782,9 +787,6 @@ static void clear_region(UI *ui, int top, int bot, int left, int right,
data->did_resize = false;
}
}
// restore cursor
cursor_goto(ui, data->row, data->col);
}
static void set_scroll_region(UI *ui, int top, int bot, int left, int right)
@ -808,7 +810,7 @@ static void set_scroll_region(UI *ui, int top, int bot, int left, int right)
unibi_out(ui, unibi_set_right_margin_parm);
}
}
unibi_goto(ui, grid->row, grid->col);
grid->row = -1;
}
static void reset_scroll_region(UI *ui, bool fullwidth)
@ -836,7 +838,7 @@ static void reset_scroll_region(UI *ui, bool fullwidth)
}
unibi_out_ext(ui, data->unibi_ext.disable_lr_margin);
}
unibi_goto(ui, grid->row, grid->col);
grid->row = -1;
}
static void tui_grid_resize(UI *ui, Integer g, Integer width, Integer height)
@ -864,6 +866,7 @@ static void tui_grid_resize(UI *ui, Integer g, Integer width, Integer height)
}
} else { // Already handled the SIGWINCH signal; avoid double-resize.
got_winch = false;
grid->row = -1;
}
}
@ -880,9 +883,10 @@ static void tui_grid_clear(UI *ui, Integer g)
static void tui_grid_cursor_goto(UI *ui, Integer grid, Integer row, Integer col)
{
TUIData *data = ui->data;
// cursor position is validated in tui_flush
data->row = (int)row;
data->col = (int)col;
cursor_goto(ui, (int)row, (int)col);
}
CursorShape tui_cursor_decode_shape(const char *shape_str)
@ -1070,7 +1074,6 @@ static void tui_grid_scroll(UI *ui, Integer g, Integer startrow, Integer endrow,
if (!data->scroll_region_is_full_screen) {
reset_scroll_region(ui, fullwidth);
}
cursor_goto(ui, data->row, data->col);
if (!(data->bce || no_bg(ui, data->clear_attrs))) {
// Scrolling will leave wrong background in the cleared area on non-BCE

View File

@ -32,7 +32,6 @@ void ugrid_resize(UGrid *grid, int width, int height)
grid->cells[i] = xcalloc((size_t)width, sizeof(UCell));
}
grid->row = grid->col = 0;
grid->width = width;
grid->height = height;
}