IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

refactor(api): use arena when listing objects

Browse Source
This commit is contained in:
bfredl 2024-02-19 10:44:57 +01:00
parent abb8dcd889
commit d14eefaee9
2 changed files with 20 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/nvim/api/tabpage.c
View File

@ -19,7 +19,7 @@
/// @param tabpage Tabpage handle, or 0 for current tabpage /// @param tabpage Tabpage handle, or 0 for current tabpage
/// @param[out] err Error details, if any /// @param[out] err Error details, if any
/// @return List of windows in `tabpage` /// @return List of windows in `tabpage`
ArrayOf(Window) nvim_tabpage_list_wins(Tabpage tabpage, Error *err) ArrayOf(Window) nvim_tabpage_list_wins(Tabpage tabpage, Arena *arena, Error *err)
FUNC_API_SINCE(1) FUNC_API_SINCE(1)
{ {
Array rv = ARRAY_DICT_INIT; Array rv = ARRAY_DICT_INIT;
@ -29,15 +29,15 @@ ArrayOf(Window) nvim_tabpage_list_wins(Tabpage tabpage, Error *err)
return rv; return rv;
} }
size_t n = 0;
FOR_ALL_WINDOWS_IN_TAB(wp, tab) { FOR_ALL_WINDOWS_IN_TAB(wp, tab) {
rv.size++; n++;
} }
rv.items = xmalloc(sizeof(Object) * rv.size); rv = arena_array(arena, n);
size_t i = 0;
FOR_ALL_WINDOWS_IN_TAB(wp, tab) { FOR_ALL_WINDOWS_IN_TAB(wp, tab) {
rv.items[i++] = WINDOW_OBJ(wp->handle); ADD_C(rv, WINDOW_OBJ(wp->handle));
} }
return rv; return rv;

33
src/nvim/api/vim.c
View File

@ -832,20 +832,19 @@ void nvim_err_writeln(String str)
/// Use |nvim_buf_is_loaded()| to check if a buffer is loaded. /// Use |nvim_buf_is_loaded()| to check if a buffer is loaded.
/// ///
/// @return List of buffer handles /// @return List of buffer handles
ArrayOf(Buffer) nvim_list_bufs(void) ArrayOf(Buffer) nvim_list_bufs(Arena *arena)
FUNC_API_SINCE(1) FUNC_API_SINCE(1)
{ {
Array rv = ARRAY_DICT_INIT; size_t n = 0;
FOR_ALL_BUFFERS(b) { FOR_ALL_BUFFERS(b) {
rv.size++; n++;
} }
rv.items = xmalloc(sizeof(Object) * rv.size); Array rv = arena_array(arena, n);
size_t i = 0;
FOR_ALL_BUFFERS(b) { FOR_ALL_BUFFERS(b) {
rv.items[i++] = BUFFER_OBJ(b->handle); ADD_C(rv, BUFFER_OBJ(b->handle));
} }
return rv; return rv;
@ -887,20 +886,19 @@ void nvim_set_current_buf(Buffer buffer, Error *err)
/// Gets the current list of window handles. /// Gets the current list of window handles.
/// ///
/// @return List of window handles /// @return List of window handles
ArrayOf(Window) nvim_list_wins(void) ArrayOf(Window) nvim_list_wins(Arena *arena)
FUNC_API_SINCE(1) FUNC_API_SINCE(1)
{ {
Array rv = ARRAY_DICT_INIT; size_t n = 0;
FOR_ALL_TAB_WINDOWS(tp, wp) { FOR_ALL_TAB_WINDOWS(tp, wp) {
rv.size++; n++;
} }
rv.items = xmalloc(sizeof(Object) * rv.size); Array rv = arena_array(arena, n);
size_t i = 0;
FOR_ALL_TAB_WINDOWS(tp, wp) { FOR_ALL_TAB_WINDOWS(tp, wp) {
rv.items[i++] = WINDOW_OBJ(wp->handle); ADD_C(rv, WINDOW_OBJ(wp->handle));
} }
return rv; return rv;
@ -1124,20 +1122,19 @@ void nvim_chan_send(Integer chan, String data, Error *err)
/// Gets the current list of tabpage handles. /// Gets the current list of tabpage handles.
/// ///
/// @return List of tabpage handles /// @return List of tabpage handles
ArrayOf(Tabpage) nvim_list_tabpages(void) ArrayOf(Tabpage) nvim_list_tabpages(Arena *arena)
FUNC_API_SINCE(1) FUNC_API_SINCE(1)
{ {
Array rv = ARRAY_DICT_INIT; size_t n = 0;
FOR_ALL_TABS(tp) { FOR_ALL_TABS(tp) {
rv.size++; n++;
} }
rv.items = xmalloc(sizeof(Object) * rv.size); Array rv = arena_array(arena, n);
size_t i = 0;
FOR_ALL_TABS(tp) { FOR_ALL_TABS(tp) {
rv.items[i++] = TABPAGE_OBJ(tp->handle); ADD_C(rv, TABPAGE_OBJ(tp->handle));
} }
return rv; return rv;