From d15a66d80336ff3f6c69a0eff4c17c83a84d44c9 Mon Sep 17 00:00:00 2001 From: kylo252 <59826753+kylo252@users.noreply.github.com> Date: Mon, 18 Jul 2022 15:18:15 +0200 Subject: [PATCH] ci(windows): config and build before publish step (#19416) Problem: Windows package step failed (silently). Solution: Make sure to configure cmake before attempting to build the package target. --- .github/workflows/release.yml | 7 +++++-- ci/build.ps1 | 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 11cc1ab03d..2d57c09ab8 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -127,7 +127,7 @@ jobs: env: DEPS_BUILD_DIR: ${{ format('{0}/nvim-deps', github.workspace) }} DEPS_PREFIX: ${{ format('{0}/nvim-deps/usr', github.workspace) }} - CONFIGURATION: ${{ matrix.config }} + CMAKE_BUILD_TYPE: "RelWithDebInfo" strategy: matrix: include: @@ -138,7 +138,10 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 0 - - run: powershell ci\build.ps1 -Package + - name: Build deps + run: .\ci\build.ps1 -BuildDeps + - name: build package + run: .\ci\build.ps1 -Package - uses: actions/upload-artifact@v3 with: name: ${{ matrix.archive }} diff --git a/ci/build.ps1 b/ci/build.ps1 index f5ebe10b87..6c042f9116 100644 --- a/ci/build.ps1 +++ b/ci/build.ps1 @@ -134,7 +134,8 @@ function TestOld { function Package { - cmake --build $buildDir --target package + cmake -S $projectDir -B $buildDir $(convertToCmakeArgs($nvimCmakeVars)) -G Ninja; exitIfFailed + cmake --build $buildDir --target package; exitIfFailed } if ($PSCmdlet.ParameterSetName) {