IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.1.1052: tests: off-by-one error in CheckCWD in test_debugger.vim (#32202)

Browse Source 
Problem:  tests: off-by-one error in CheckCWD in test_debugger.vim
Solution: Fix off-by-one in CheckCWD leading to local tests failure
          (Yee Cheng Chin)

Vim's test_debugger's Test_debug_backtrace_level test will fail if you
happen to run it in a Vim repository with full path of directory being
exactly 29 characters (e.g. `/Users/bob/developing/src/vim`). The test
does term dump comparison and the printout will overflow if the CWD is
too long. It does have a function to skip to test if it detects that but
it's off by one leading to this one situation where it will fail.

The reason why the logic didn't account for this is that Vim's message
printing will overflow the text if it prints a message at exactly the
width of the terminal. This could be considered a bug / quirk but that
will be another issue.

closes: vim/vim#16517

3acfbb4b54

Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
This commit is contained in:
zeertzjq 2025-01-25 23:03:43 +08:00 committed by GitHub
parent fb1740521a
commit d4a65dad23
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/old/testdir/test_debugger.vim
View File

@ -6,10 +6,11 @@ source check.vim
func CheckCWD() func CheckCWD()
" Check that the longer lines don't wrap due to the length of the script name " Check that the longer lines don't wrap due to the length of the script name
" in cwd " in cwd. Need to subtract by 1 since Vim will still wrap the message if it
" just fits.
let script_len = len( getcwd() .. '/Xtest1.vim' ) let script_len = len( getcwd() .. '/Xtest1.vim' )
let longest_line = len( 'Breakpoint in "" line 1' ) let longest_line = len( 'Breakpoint in "" line 1' )
if script_len > ( 75 - longest_line ) if script_len > ( 75 - longest_line - 1 )
throw 'Skipped: Your CWD has too many characters' throw 'Skipped: Your CWD has too many characters'
endif endif
endfunc endfunc