From 0c901baee11ad1961d034281d7f83f1d66292f89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dundar=20G=C3=B6c?= Date: Fri, 11 Feb 2022 16:09:12 +0100 Subject: [PATCH] revert: "ci: use continue-on-error instead of "|| true"" This reverts commit 559aa4179c639f5ebd45474a36361343ac2371cf. I mistakenly believed both ways of writing were equivalent; this is untrue. Setting continue-on-error to true will make the job pass, but an error annotation will still be created which is misleading since it's not actually an error. --- .github/workflows/labeler.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index 0e20e96cb6..08f0ce1763 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -27,11 +27,9 @@ jobs: PR_TITLE: ${{ github.event.pull_request.title }} steps: - name: "Extract commit type and add as label" - continue-on-error: true - run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|([[:alpha:]]+)(\(.*\))?!?:.*|\1|')" + run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|([[:alpha:]]+)(\(.*\))?!?:.*|\1|')" || true - name: "Extract commit scope and add as label" - continue-on-error: true - run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|[[:alpha:]]+\((.+)\)!?:.*|\1|')" + run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|[[:alpha:]]+\((.+)\)!?:.*|\1|')" || true upload-pr-number: runs-on: ubuntu-latest