IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

coverity/75594: Explicit null dereferenced: RI.

Browse Source 
Problem    : Exlicit null dereferenced (FORWARD NULL) @ 2859.
Diagnostic : Real issue.
Rationale  : Code within `if (!p_bk)` seems to assume `backup` not null
             at that point, which may not be true.
Resolution : Don't enter conditional on null `backup`.
This commit is contained in:
Eliseo Martínez 2014-12-16 13:37:56 +01:00
parent 85ee4b83ac
commit e0b23b3d09
1 changed files with 15 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/nvim/fileio.c
View File

@ -2839,27 +2839,25 @@ buf_write (
* Check if backup file already exists. * Check if backup file already exists.
*/ */
if (os_fileinfo((char *)backup, &file_info_new)) { if (os_fileinfo((char *)backup, &file_info_new)) {
/*
* Check if backup file is same as original file.
* May happen when modname() gave the same file back (e.g. silly
* link). If we don't check here, we either ruin the file when
* copying or erase it after writing.
*/
if (os_fileinfo_id_equal(&file_info_new, &file_info_old)) { if (os_fileinfo_id_equal(&file_info_new, &file_info_old)) {
/*
* Backup file is same as original file.
* May happen when modname() gave the same file back (e.g. silly
* link). If we don't check here, we either ruin the file when
* copying or erase it after writing.
*/
free(backup); free(backup);
backup = NULL; /* no backup file to delete */ backup = NULL; /* no backup file to delete */
} } else if (!p_bk) {
/*
/* * We are not going to keep the backup file, so don't
* If we are not going to keep the backup file, don't * delete an existing one, and try to use another name instead.
* delete an existing one, try to use another name. * Change one character, just before the extension.
* Change one character, just before the extension. */
*/ wp = backup + STRLEN(backup) - 1 - STRLEN(backup_ext);
if (!p_bk) { if (wp < backup) { /* empty file name ??? */
wp = backup + STRLEN(backup) - 1
- STRLEN(backup_ext);
if (wp < backup) /* empty file name ??? */
wp = backup; wp = backup;
}
*wp = 'z'; *wp = 'z';
while (*wp > 'a' while (*wp > 'a'
&& os_fileinfo((char *)backup, &file_info_new)) { && os_fileinfo((char *)backup, &file_info_new)) {