From e2d71d11de9282521e931d832a92154acd341ef0 Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Wed, 2 Jan 2019 23:18:31 +0100 Subject: [PATCH] remove check_visual_highlight() This check is meaningless, we assume the terminal supports reverse-mode. --- src/nvim/mouse.c | 1 - src/nvim/normal.c | 18 ------------------ src/nvim/screen.c | 3 +-- 3 files changed, 1 insertion(+), 21 deletions(-) diff --git a/src/nvim/mouse.c b/src/nvim/mouse.c index 3790886194..bf71e6a479 100644 --- a/src/nvim/mouse.c +++ b/src/nvim/mouse.c @@ -319,7 +319,6 @@ retnomove: // Start Visual mode before coladvance(), for when 'sel' != "old" if ((flags & MOUSE_MAY_VIS) && !VIsual_active) { - check_visual_highlight(); VIsual = old_cursor; VIsual_active = true; VIsual_reselect = true; diff --git a/src/nvim/normal.c b/src/nvim/normal.c index a050c95224..8733c6db62 100644 --- a/src/nvim/normal.c +++ b/src/nvim/normal.c @@ -2764,7 +2764,6 @@ do_mouse ( if (VIsual_active) orig_cursor = VIsual; else { - check_visual_highlight(); VIsual = curwin->w_cursor; orig_cursor = VIsual; VIsual_active = true; @@ -2934,22 +2933,6 @@ static int get_mouse_class(char_u *p) return c; } -/* - * Check if highlighting for visual mode is possible, give a warning message - * if not. - */ -void check_visual_highlight(void) -{ - static bool did_check = false; - - if (full_screen) { - if (!did_check && HL_ATTR(HLF_V) == 0) { - MSG(_("Warning: terminal cannot highlight")); - } - did_check = true; - } -} - /* * End Visual mode. * This function should ALWAYS be called to end Visual mode, except from @@ -6420,7 +6403,6 @@ static void nv_visual(cmdarg_T *cap) } redraw_curbuf_later(INVERTED); /* update the inversion */ } else { /* start Visual mode */ - check_visual_highlight(); if (cap->count0 > 0 && resel_VIsual_mode != NUL) { /* use previously selected part */ VIsual = curwin->w_cursor; diff --git a/src/nvim/screen.c b/src/nvim/screen.c index 1e07bbb5e3..07695031d8 100644 --- a/src/nvim/screen.c +++ b/src/nvim/screen.c @@ -678,8 +678,7 @@ static void win_update(win_T *wp) static int recursive = FALSE; /* being called recursively */ int old_botline = wp->w_botline; long fold_count; - /* remember what happened to the previous line, to know if - * check_visual_highlight() can be used */ + // Remember what happened to the previous line. #define DID_NONE 1 /* didn't update a line */ #define DID_LINE 2 /* updated a normal line */ #define DID_FOLD 3 /* updated a folded line */