IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

memline: Don't call memmove() with a NULL argument in ml_add_stack(). #2802

Browse Source 
When ml_add_stack() needs to increase the size of the empty stack,
buf->b_ml.ml_stack is NULL and is used as argument in memmove().
This is undefined behaviour. Declaration of memmove() in string.h:

extern void *memmove (void *__dest, const void *__src, size_t __n)
     __THROW __nonnull ((1, 2));
This commit is contained in:
oni-link 2015-06-07 12:04:13 +02:00 committed by Justin M. Keyes
parent be66c0b357
commit e53dda90bd
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/nvim/memline.c
View File

@ -2936,12 +2936,9 @@ static int ml_add_stack(buf_T *buf)
if (top == buf->b_ml.ml_stack_size) { if (top == buf->b_ml.ml_stack_size) {
CHECK(top > 0, _("Stack size increases")); /* more than 5 levels??? */ CHECK(top > 0, _("Stack size increases")); /* more than 5 levels??? */
infoptr_T *newstack = xmalloc(sizeof(infoptr_T) *
(buf->b_ml.ml_stack_size + STACK_INCR));
memmove(newstack, buf->b_ml.ml_stack, (size_t)top * sizeof(infoptr_T));
xfree(buf->b_ml.ml_stack);
buf->b_ml.ml_stack = newstack;
buf->b_ml.ml_stack_size += STACK_INCR; buf->b_ml.ml_stack_size += STACK_INCR;
size_t new_size = sizeof(infoptr_T) * buf->b_ml.ml_stack_size;
buf->b_ml.ml_stack = xrealloc(buf->b_ml.ml_stack, new_size);
} }
buf->b_ml.ml_stack_top++; buf->b_ml.ml_stack_top++;