IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

regexp: Silence V595: potential null dereference

Browse Source 
The code uses 2-iteration loop antipattern: retval is NULL on first iteration, 
not NULL on second, yet this is still a false positive.
This commit is contained in:
ZyX 2017-07-04 17:28:33 +03:00
parent 6552768c4f
commit f81d1ce003
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/nvim/regexp.c
View File

@ -6928,9 +6928,10 @@ char_u *reg_submatch(int no)
STRNCPY(retval + len, reg_getline_submatch(lnum), STRNCPY(retval + len, reg_getline_submatch(lnum),
submatch_mmatch->endpos[no].col); submatch_mmatch->endpos[no].col);
len += submatch_mmatch->endpos[no].col; len += submatch_mmatch->endpos[no].col;
if (round == 2) if (round == 2) {
retval[len] = NUL; retval[len] = NUL; // -V595
++len; }
len++;
} }
if (retval == NULL) { if (retval == NULL) {