From c5df2f38ff2d1ceca0e9eedc966390a8c757cb97 Mon Sep 17 00:00:00 2001 From: Thiago de Arruda Date: Thu, 29 Jan 2015 11:01:25 -0300 Subject: [PATCH 1/2] travis: Install neovim module for testing the python provider. python_spec.lua depends on the python client installed. --- .ci/common.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.ci/common.sh b/.ci/common.sh index bb6c5758d6..29c2a17c51 100644 --- a/.ci/common.sh +++ b/.ci/common.sh @@ -46,6 +46,7 @@ check_core_dumps() { } setup_deps() { + sudo pip install neovim if [ "$BUILD_NVIM_DEPS" != "true" ]; then eval "$(curl -Ss https://raw.githubusercontent.com/neovim/bot-ci/master/scripts/travis-setup.sh) deps-${1}" elif [ "$TRAVIS_OS_NAME" = "linux" ]; then From bdba32ffd9cac722358424921b2e924ed876a902 Mon Sep 17 00:00:00 2001 From: Thiago de Arruda Date: Thu, 29 Jan 2015 11:04:03 -0300 Subject: [PATCH 2/2] test: Mark unreliable test as pending in job_spec.lua `job_send` is non-blocking and can potentially fail due to the following `job_stop` call. Since we can't reliably verify that the "exit" event is only sent after the "stdout" event, mark the test as pending and fix after we can get a notification about `job_send` status. --- test/functional/job/job_spec.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/functional/job/job_spec.lua b/test/functional/job/job_spec.lua index 07ca0c0058..5304c9e9d3 100644 --- a/test/functional/job/job_spec.lua +++ b/test/functional/job/job_spec.lua @@ -97,7 +97,8 @@ describe('jobs', function() nvim('command', "call jobstart('xxx', 'cat', ['-'])") end) - it('will only emit the "exit" event after "stdout" and "stderr"', function() + -- FIXME need to wait until jobsend succeeds before calling jobstop + pending('will only emit the "exit" event after "stdout" and "stderr"', function() nvim('command', notify_job()) nvim('command', "let j = jobstart('xxx', 'cat', ['-'])") local jobid = nvim('eval', 'j')