IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: check for valid buffer handles in modify_keymap (#13543)

Browse Source 
Fixes #13541
Neovim would crash when trying to map a key on non existant buffer
This commit is contained in:
Thomas Vigouroux 2021-01-03 19:14:18 +01:00 committed by GitHub
parent ae63dc264a
commit fd960a33e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/api/private/helpers.c
View File

@ -820,6 +820,10 @@ void modify_keymap(Buffer buffer, bool is_unmap, String mode, String lhs,
} }
buf_T *target_buf = find_buffer_by_handle(buffer, err); buf_T *target_buf = find_buffer_by_handle(buffer, err);
if (!target_buf) {
return;
}
MapArguments parsed_args; MapArguments parsed_args;
memset(&parsed_args, 0, sizeof(parsed_args)); memset(&parsed_args, 0, sizeof(parsed_args));
if (parse_keymap_opts(opts, &parsed_args, err)) { if (parse_keymap_opts(opts, &parsed_args, err)) {

5
test/functional/api/keymap_spec.lua
View File

@ -809,4 +809,9 @@ describe('nvim_buf_set_keymap, nvim_buf_del_keymap', function()
command('normal lhs') command('normal lhs')
eq({'rhs'}, bufmeths.get_lines(0, 0, 1, 1)) eq({'rhs'}, bufmeths.get_lines(0, 0, 1, 1))
end) end)
it("does not crash when setting keymap in a non-existing buffer #13541", function()
pcall_err(bufmeths.set_keymap, 100, '', 'lsh', 'irhs<Esc>', {})
helpers.assert_alive()
end)
end) end)