Eliseo Martínez
a32442db85
Fix warnings: screen.c: redraw_asap(): Various (6): MI.
...
Problems: Argument with 'nonnull' attribute passed null @ 277.
http://neovim.org/doc/reports/clang/report-9c3614.html#EndPath
Result of operation is garbage or undefined @ 281.
http://neovim.org/doc/reports/clang/report-45efbf.html#EndPath
Argument with 'nonnull' attribute passed null @ 306.
http://neovim.org/doc/reports/clang/report-ffb84f.html#EndPath
Result of operation is garbage or undefined @ 311.
http://neovim.org/doc/reports/clang/report-d04333.html#EndPath
Argument with 'nonnull' attribute passed null @ 315.
http://neovim.org/doc/reports/clang/report-786819.html#EndPath
Uninitialized argument value @ 328.
http://neovim.org/doc/reports/clang/report-2a5506.html#EndPath
Diagnostic: Multithreading issues.
Rationale : All reported problems can only occur if accesed globals
change state while executing function, which could only
happen in a multithreaded environment.
Resolution: Use local variables.
Note that this change alters function semantics, as now
function only depends on global values at entry time.
This shouldn't be a problem, though, as new semantics should
be in fact better.
2014-11-06 09:51:42 +01:00
Eliseo Martínez
b6c1fae6a9
Fix warnings: cursor_shape.c: parse_shape_opt(): Garbage value: FP.
...
Problem: Assigned value is garbage or undefined @ 187.
http://neovim.org/doc/reports/clang/report-7b7d61.html#EndPath .
Diagnostic: False positive.
Rationale : `colonp`, must be `>= modep, or null` by `vim_strchr`
postcondition. At this point we also it's not null and it's
not equal to `modep`, by previous code. So, it must be
`> modep`.
Resolution: Assert `colonp > modep`.
2014-11-06 09:51:42 +01:00
Thiago de Arruda
4cc26fba24
Merge PR #1398 'Tests and msgpack rpc improvements'
2014-11-06 04:36:46 -03:00
Thiago de Arruda
d83868fe90
channel: Delay notifications to avoid client race conditions
...
It is currently possible for a client to send a response that doesn't match the
current server->client request(at the top of the stack). This commit fixes that
by delaying notifications to until the first `channel_send_call` invocation
returns.
Also remove the "call stack" size check, vim will already break if the call
stack goes too deep.
2014-11-06 04:22:06 -03:00
Thiago de Arruda
8979ede45d
test: Add more valgrind "possibly lost" suppressions
...
These valgrind entries are false positives because vim uses interior pointers.
2014-11-06 04:22:06 -03:00
Thiago de Arruda
117d3db6d7
test: Simplify/fix options_spec.lua
...
The options_spec.lua suite has one purpose: Check if the :options commands will
throw any exception(:options is implemented by $VIMRUNTIME/optwin.vim). For this
it is best to use the `vim_command` API function since it will automatically
catch exceptions and forward them via msgpack-rpc.
Also, the option window seems to affect other tests, so call `restart` in the
teardown hook.
2014-11-06 04:21:57 -03:00
Nicolas Hillegeer
8c5efd62ac
iconv: re-enable
...
This seems to have been disabled in the transition from vim to neovim,
re-enable it.
2014-11-06 00:18:26 +01:00
Thiago de Arruda
5e5525a78b
test: Set VIMRUNTIME before running tests
...
This is required for testing scripts under the 'runtime' directory
2014-11-05 14:02:04 -03:00
John Szakmeister
3972715ce7
Merge pull request #1397 from fwalch/fix-test_file
...
Restore TEST_FILE functionality for running individual tests.
2014-11-05 09:33:03 -05:00
Florian Walch
afa5831d73
CMake: Fix running individual (functional/unit) test.
2014-11-05 13:57:29 +01:00
John Szakmeister
e0628dab49
Merge pull request #1395 from jszakmeister/fix-run-functional-tests
...
build: fix running of functional tests directly with CMake
2014-11-05 07:53:53 -05:00
John Szakmeister
5ba1d980fb
build: fix running of functional tests directly with CMake
...
If you aren't just building everything into build/, then the functional
tests fail because they can't find the nvim executable. Let's pass in
the location of the nvim executable, and set NVIM_PRG environment
variable accordingly.
2014-11-05 07:26:35 -05:00
John Szakmeister
d1675de0a9
Merge pull request #1392 from fwalch/fix-build-warnings
...
Fix build warnings.
2014-11-05 06:46:49 -05:00
Florian Walch
b904c33e41
CMake: Rename target "test" to "functionaltest".
...
Remove build warning:
The target name "test" is reserved or not valid for certain CMake
features, such as generator expressions, and may result in undefined
behavior.
2014-11-05 11:54:20 +01:00
Florian Walch
5714afc11e
CMake: Modify _FORTIFY_SOURCE only for release builds.
...
Remove build warning for Debug builds:
# warning _FORTIFY_SOURCE requires compiling with optimization (-O)
2014-11-05 11:54:15 +01:00
Florian Walch
58b87579cf
CMake: Pass build type CFLAGS to header generator.
2014-11-05 11:54:05 +01:00
John Szakmeister
83d9b36214
Merge pull request #1390 from jszakmeister/turn-down-fortify-source
...
build: turn down the _FORTIFY_SOURCE level on gcc >= 4.0
2014-11-05 04:06:40 -05:00
John Szakmeister
64ea00299d
build: turn down the _FORTIFY_SOURCE level on gcc >= 4.0
2014-11-05 03:53:31 -05:00
Thiago de Arruda
04633e3e6b
Merge PR #1328 'Migrate legacy tests'
2014-11-04 12:59:09 -03:00
Rainer Borene
a695c87863
legacy tests: migrate test21
2014-11-04 12:57:33 -03:00
Rainer Borene
2d8d4285e4
legacy tests: migrate test7
2014-11-04 12:57:33 -03:00
Rainer Borene
ef08a2c0df
legacy tests: migrate test6
2014-11-04 12:57:33 -03:00
Rainer Borene
38bef424a2
legacy tests: migrate test28
2014-11-04 12:57:33 -03:00
Rainer Borene
ca0a55c2a9
legacy tests: migrate test20
2014-11-04 12:57:33 -03:00
Rainer Borene
afe9aa758e
legacy tests: migrate test97
2014-11-04 12:57:33 -03:00
Rainer Borene
5ea94e14f0
legacy tests: migrate test46
2014-11-04 12:57:33 -03:00
Rainer Borene
ac52d84f16
legacy tests: migrate test27
2014-11-04 12:57:33 -03:00
Rainer Borene
34cc2b1e33
legacy tests: migrate test54
2014-11-04 12:57:33 -03:00
Rainer Borene
fd503f1432
legacy tests: migrate test41
2014-11-04 12:57:33 -03:00
Rainer Borene
f85051b67e
legacy tests: migrate test23
2014-11-04 12:57:33 -03:00
Rainer Borene
ffd5c43e84
legacy tests: migrate test56
2014-11-04 12:57:33 -03:00
Rainer Borene
4873171fc6
legacy tests: migrate test_autoformat_join
2014-11-04 12:57:33 -03:00
Rainer Borene
b67ad4f67f
legacy tests: migrate test_changelist
2014-11-04 12:57:33 -03:00
Rainer Borene
4ca353d3bd
legacy tests: migrate test81
2014-11-04 12:57:33 -03:00
Rainer Borene
79cd4a98ec
legacy tests: migrate test_utf8
2014-11-04 12:57:33 -03:00
Rainer Borene
683b75d052
legacy tests: migrate test_insertcount
2014-11-04 12:57:33 -03:00
Rainer Borene
5b7d9bbd08
legacy tests: migrate test_options
2014-11-04 12:57:32 -03:00
Rainer Borene
b33c92439b
legacy tests: migrate test18
2014-11-04 12:57:32 -03:00
Rainer Borene
481c449c72
legacy tests: migrate test106
2014-11-04 12:57:32 -03:00
Rainer Borene
6c90902c7a
legacy tests: migrate test22
2014-11-04 12:57:32 -03:00
Rainer Borene
b780e946d5
legacy tests: migrate test9
2014-11-04 12:57:32 -03:00
Rainer Borene
d4f92e521c
legacy tests: migrate test102
2014-11-04 12:57:32 -03:00
Rainer Borene
dbc7a8d987
legacy tests: migrate test4
2014-11-04 12:57:32 -03:00
Rainer Borene
649aeceb38
legacy tests: improvements to functional helpers.lua
...
- Clean vim registers and functions before each test
- Add eval workaround to the request helper method
- Export dedent method
2014-11-04 12:57:32 -03:00
Thiago de Arruda
1d250cddb8
Merge pull request #1287 '[RFC] Add legacy test conversion script.'
2014-11-04 11:38:19 -03:00
Florian Walch
bc6ac59928
Add legacy test conversion script.
2014-11-04 11:38:06 -03:00
Thiago de Arruda
5f99be1efe
Merge pull request #1376 '[RDY] Passing current range to provider calls'
2014-11-04 10:58:01 -03:00
henadzit
e5389600ec
Passing current range to provider calls
...
- updated script_host_execute and script_host_execute_file to pass current range
2014-11-04 09:47:06 -03:00
Thiago de Arruda
13a38ff688
Merge PR #1384 'Add core dump reporting to travis'
2014-11-03 21:59:18 -03:00
Thiago de Arruda
7cff10a6c5
test: Add valgrind suppression for libuv memory leak
...
A memory leak happens in uv_spawn when stdio is set to UV_IGNORE and the child
process fails to start. This only happens when libuv is compiled with gcc and
optimizations enabled(the default).
Compiling with '-O0' removes the leak, but all that can be done right now is
ignore the leak by adding a valgrind suppression.
2014-11-03 21:51:51 -03:00