Commit Graph

15295 Commits

Author SHA1 Message Date
Jan Edmund Lazo
63983316bd
vim-patch:8.2.0014: test69 and test95 are old style
Problem:    Test69 and test95 are old style.
Solution:   Convert to new style tests. (Yegappan Lakshmanan, closes vim/vim#5365)
afc13bd827
2020-01-30 21:29:21 -05:00
Axel Forsman
2538e61513
Fix shift change callbacks reading bad cursor (#11782)
Sloppy code inherited from Vim caused user scripts to be able
to observe the cursor line in an invalid intermediary state,
due to Neovim change callbacks being unbuffered unlike Vim listeners.

Manifested in Vimscript executed from the callback possibly erroring
when `:call`:ing any function,
due to the implicit range `curwin->w_cursor.lnum,curwin->w_cursor.lnum`
failing validation.

Fixed by deferring the call to `changed_lines()` until after
`curwin->w_cursor.lnum` gets its correct value.
2020-01-30 07:34:34 +01:00
Justin M. Keyes
4ea5d7d31a
Merge #11792 from janlazo/vim-8.1.0445
vim-patch:8.1.{445,446},8.2.{77,177}
2020-01-29 20:30:23 -08:00
Jan Edmund Lazo
b7447a909f
vim-patch:8.2.0177: memory leak in get_tags()
Problem:    Memory leak in get_tags().
Solution:   Free matches when finding a pseudo-tag line. (Dominique Pelle,
            closes vim/vim#5553)
70b3e706b4
2020-01-29 22:18:58 -05:00
Jan Edmund Lazo
31f31b40a8
vim-patch:8.2.0077: settagstack() cannot truncate at current index
Problem:    settagstack() cannot truncate at current index.
Solution:   Add the "t" action. (Yegappan Lakshmanan, closes vim/vim#5417)
271fa08a35
2020-01-29 21:00:11 -05:00
Jan Edmund Lazo
f719b8898b
vim-patch:8.1.0446: options test fails in the GUI
Problem:    Options test fails in the GUI.
Solution:   Don't try changing 'term' in the GUI.
4f88875725
2020-01-29 20:31:16 -05:00
Jan Edmund Lazo
ca08d5c191
vim-patch:8.1.0445: setting 'term' does not store location for termcap options
Problem:    Setting 'term' does not store location for termcap options.
Solution:   Set the script context for termcap options that are changed when
            'term' is set.
35bc7d6c52
2020-01-29 20:30:40 -05:00
Björn Linse
406464fa6e
CONTRIBUTING.md: mention "good first issue" label 2020-01-29 12:06:35 +01:00
Jan Edmund Lazo
0b49cb67f2
vim-patch:8.2.0171: fix use of uninitialized buffer #11786
Problem:    Coverity warning for using uninitialized buffer.
Solution:   Check the skip flag.
9a5e5a3e33
2020-01-28 23:02:11 -08:00
Björn Linse
01ff9db633
Merge pull request #11780 from bfredl/winhlparse
options: winhighlight: fix incorrect string equality test
2020-01-28 22:23:35 +01:00
Björn Linse
bfe84adb5a options: winhighlight: fix incorrect string equality test 2020-01-28 19:10:41 +01:00
Matthieu Coudron
e956ea7672 LSP: show diagnostic in qf/loclist #11777
instead of the content of the file at this line.

ref https://github.com/neovim/nvim-lsp/issues/69
2020-01-28 01:45:25 -08:00
Justin M. Keyes
b2062368e7
Merge #11775 'refactor: move session fns to ex_session.c'
obviates vim patch:
vim-patch:8.1.1766
2020-01-28 01:35:38 -08:00
erw7
4d0dfb8f75 build/MSVC: fix gettext multibyte issue #11774
Problem:  On Windows with the MSVC build, gettext-translation
          "Questa è già la" displays as "Questa <e8> gi<e0> la".
Solution: Fix iconv detection iconv when building gettext.
          So HAVE_ICONV is correctly defined when building nvim.

* fix gettext mb chars on MSVC
* fix libintl detection failure on MSVC

fixes #11749
2020-01-28 00:56:26 -08:00
Justin M. Keyes
a4b9417c78 lint 2020-01-28 00:22:14 -08:00
Justin M. Keyes
75e8562249 refactor: move session functions to ex_session.c 2020-01-28 00:22:14 -08:00
Justin M. Keyes
d3a9d75c04
Merge #11772 from janlazo/vim-8.2.0152
vim-patch:8.2.{152,158}
2020-01-26 19:54:26 -08:00
Justin M. Keyes
b5daee7b8f
Merge #7836 'session: restore same :terminal buf split windows' 2020-01-26 19:03:43 -08:00
Jan Edmund Lazo
5ede2766c8
vim-patch:8.2.0158: triggering CompleteDone earlier is not backwards compatible
Problem:    Triggering CompleteDone earlier is not backwards compatible.
            (Daniel Hahler)
Solution:   Add CompleteDonePre instead.
3f169ce17e
2020-01-26 21:50:37 -05:00
Jan Edmund Lazo
e673a0df1a
vim-patch:8.2.0152: restoring ctrl_x_mode is not needed
Problem:    Restoring ctrl_x_mode is not needed.
Solution:   Remove restoring the old value, it's changed again soon.
da812e282a
2020-01-26 21:17:54 -05:00
Justin M. Keyes
1c3ca4f18f mksession: always unix slashes "/" for filepaths 2020-01-26 17:30:47 -08:00
Justin M. Keyes
c4f4719ced cleanup/ex_docmd.c: remove most put_eol() calls 2020-01-26 17:13:00 -08:00
Justin M. Keyes
9048627806 lint 2020-01-26 17:13:00 -08:00
Justin M. Keyes
2070c082b5 cleanup/ex_docmd.c: remove most put_line() calls
- prefer fprintf() instead of put_line()
- PUTLINE_FAIL macro to avoid some boilerplate
2020-01-26 17:13:00 -08:00
Justin M. Keyes
2c1d12d0be mksession: always write LF "\n" line-endings
- remove `MKSESSION_NL`, `mksession_nl`
- deprecate the "unix" flag of 'sessionoptions'

There is no reason to choose CRLF or LF for session files. Instead just
always write LF.
2020-01-26 17:13:00 -08:00
Justin M. Keyes
598a1cd7c5 mksession: avoid ":file …" when restoring non-terminal bufs 2020-01-26 17:13:00 -08:00
Justin M. Keyes
1e103b3c12 mksession: simplify generated commands
Doing ":file …" immediately after is enough to fixup the :terminal
buffer name.

ref #5250
2020-01-26 17:13:00 -08:00
Alexandre Dubray
cf67f19ac2 mksession: restore same :term buf in split windows
Problem: When session-restore creates a terminal buffer with command
         like `:edit term://.//16450:/bin/bash`, the buffer gets
         a different name (depends on PID). Thus the later call to
         `bufexists('term://.//16450:/bin/bash)` will return false.
Solution: Force the buffer name with :file. This as least ensures
         the same buffer will show in multiple windows correctly, as
         expected when saving the session.  But it still has problems:
           1. the PID in the buffer name is bogus
           2. redundant :terminal buffers still hang around

fix #5250
2020-01-26 17:13:00 -08:00
Justin M. Keyes
88f133c30d
Merge #11763 'spell: remove non-UTF8 dead code' 2020-01-26 16:42:00 -08:00
Justin M. Keyes
9dc3247850
Merge #11766 from janlazo/vim-8.1.1143
vim-patch:8.1.{1143,1144}
2020-01-26 15:53:23 -08:00
Jan Edmund Lazo
0e1dd0a502
spell: towupper(),towlower() are not called 2020-01-26 17:44:24 -05:00
Jan Edmund Lazo
ad272cd2d7
vim-patch:8.1.1144: too strict checking of the 'spellfile' option
Problem:    Too strict checking of the 'spellfile' option.
Solution:   Allow for a path.
862f1e17ea
2020-01-26 17:38:31 -05:00
Jan Edmund Lazo
08c5a874ab
vim-patch:8.1.1143: may pass weird strings to file name expansion
Problem:    May pass weird strings to file name expansion.
Solution:   Check for matching characters.  Disallow control characters.
8f130eda47
2020-01-26 17:38:30 -05:00
Jan Edmund Lazo
d5322c8381
spellfile: set_spell_chartab() is dead code 2020-01-26 10:33:01 -05:00
Jan Edmund Lazo
eab052eca2
spell_defs: remove enc_utf8 redundant checks 2020-01-26 10:33:01 -05:00
Jan Edmund Lazo
86c1630a1b
spell: remove enc_utf8 dead code 2020-01-26 10:33:01 -05:00
Jan Edmund Lazo
6c7a995c5f
spell: zero-init structs to fix garbage ptrs 2020-01-26 10:33:00 -05:00
Björn Linse
6f073ccbf4
Merge pull request #11755 from bfredl/qf_msg
screen: add missing redraws after a message
2020-01-26 15:38:04 +01:00
Björn Linse
687fc527de screen: add missing redraws after a message 2020-01-26 13:45:20 +01:00
Justin M. Keyes
07a105f0cb
terminal: trim CWD slash #11762
Trailing CWD slash in term:// buffer name breaks the BufReadCmd
handler.

Before:
    term://~///25232:/bin/bash
After:
    term://~//25232:/bin/bash

ref c6ff23d7a0
ref #11289
2020-01-26 02:13:37 -08:00
Chris LaRose
c6ff23d7a0 terminal: absolute CWD in term:// URI #11289
This makes it possible to restore the working directory of :terminal
buffers when reading those buffers from a session file.

Fixes #11288

Co-authored-by: Justin M. Keyes <justinkz@gmail.com>
2020-01-26 00:24:42 -08:00
Jan Edmund Lazo
451af7f087 vim-patch:8.1.2171: mouse support not always available #11761
Problem:    Mouse support not always available.
Solution:   Enable mouse support also in tiny version.  Do not define
            FEAT_MOUSE_XTERM on MS-Windows (didn't really work).
a1cb1d1dce
2020-01-25 22:05:04 -08:00
Justin M. Keyes
cbcb50dcc9
shell: "..." instead of "[...]" #11760
0c1be45ea0 changed pulse logic to output "[...]" instead of nothing.
But that doesn't align with the "..." pulse which may follow it.

ref #11130
2020-01-25 16:49:53 -08:00
Justin M. Keyes
a75c289eb8
Merge #11750 from janlazo/vim-8.2.0146
vim-patch:8.1.2245,8.2.{146,147}
2020-01-25 16:21:09 -08:00
Jan Edmund Lazo
94ad6652f1
Remove enc_utf8,has_mbyte dead code 2020-01-25 18:09:17 -05:00
Jan Edmund Lazo
9d826700f7
vim-patch:8.1.2245: third character of 'listchars' tab shows in wrong place
Problem:    Third character of 'listchars' tab shows in wrong place when
            'breakindent' is set.
Solution:   Set c_final to NUL. (Naruhiko Nishino, closes vim/vim#5165)
2f7b7b1e12
2020-01-24 02:17:21 -05:00
Jan Edmund Lazo
e22d0cf12c
vim-patch:8.2.0147: block Visual mode operators not correct when 'linebreak' set
Problem:    Block Visual mode operators not correct when 'linebreak' set.
Solution:   Set w_p_lbr to lbr_saved more often. (Ken Takata, closes vim/vim#5524)
03c3bd9fd0
2020-01-24 02:02:40 -05:00
Jan Edmund Lazo
376fa27237
vim-patch:8.2.0146: wrong indent when 'showbreak' and 'breakindent' are set
Problem:    Wrong indent when 'showbreak' and 'breakindent' are set and
            'briopt' includes "sbr".
Solution:   Reset "need_showbreak" where needed. (Ken Takata, closes vim/vim#5523)
dfede9a70b
2020-01-23 19:31:11 -05:00
Jan Edmund Lazo
71ee46accf vim-patch:8.2.0141: no swift filetype detection (#11747)
Problem:    No swift filetype detection.
Solution:   Add swift, swiftgyb and sil. (Emir Sarı, closes vim/vim#5517)
0d76683e09
2020-01-23 02:21:05 +01:00
Björn Linse
91bd1ddf3b
Merge pull request #11740 from Billy4195/fix_jobstop
make jobstop() return 0 instead of throw error for already stopped job
2020-01-22 19:23:29 +01:00