Problem: bufload() reads a file even if the name is not a file name. (Cyker
Way)
Solution: Do not read the file when the buffer name is not a file name.
(closesvim/vim#10975)
2eddbacd6d
Problem: Command line completion functions are very long.
Solution: Refactor into multiple functions. (Yegappan Lakshmanan,
closesvim/vim#9753)
620d8edba0
Change fifth argument of set_context_by_cmdname() to "context".
Problem: Warnings reported by MSVC.
Solution: Rename variables and other fixes. (Ken Takata, closesvim/vim#9689)
5411910c77
N/A patches for version.c:
vim-patch:8.2.0091: compiler warnings for size_t / int types
Problem: Compiler warnings for size_t / int types.
Solution: Change type to size_t. (Mike Williams)
4d7a248b64
vim-patch:8.2.1299: compiler warning for using size_t for int and void pointer
Problem: Compiler warning for using size_t for int and void pointer.
Solution: Add type casts.
d3bb6a82a5
vim-patch:8.2.1906: warning for signed/unsigned
Problem: Warning for signed/unsigned.
Solution: Use size_t instead of int. (Mike Williams)
a360dbe3b6
vim-patch:8.2.4531: LGTM warnings for condition and buffer size
Problem: LGTM warnings for condition always true and buffer size too small.
Solution: Remove the useless condition. Make the buffer larger. (Goc
Dundar, closesvim/vim#9914)
f01a653ac5
vim-patch:8.2.4624: old Coverity warning for resource leak
Problem: Old Coverity warning for resource leak.
Solution: Close the file if memory allocation fails.
5d46dcfeed
vim-patch:9.0.0129: compiler warning for int/size_t usage
Problem: Compiler warning for int/size_t usage.
Solution: Add a type cast. (Mike Williams, closesvim/vim#10830)
ab146dac6b
Problem: Compiler warnings for int to size_t conversion. (Randall W.
Morris)
Solution: Add type casts.
551c1aed65
Still keep it size_t, but avoid calculating multiple times.
This marks the remaining part of Vim patch 8.2.3953 as ported, because
ins_compl_upd_pum() has been removed.
vim-patch:8.2.3953: insert completion code is too complicated
Problem: Insert completion code is too complicated.
Solution: More refactoring. Move function arguments into a struct.
(Yegappan Lakshmanan, closesvim/vim#9437)
6ad84ab3e4
Problem: Insert complete code uses global variables.
Solution: Make variables local to the file and use accessor functions.
(Yegappan Lakshmanan, closesvim/vim#9470)
d94fbfc74a
Skip changes in comments for callback-related functions (not ported).
Also make compl_busy static again.
Problem: Some insert completion code is not tested.
Solution: Add a few tests. Refactor thesaurus completion. (Yegappan
Lakshmanan, closesvim/vim#9460)
e982586f8e
vim-patch:9.0.0254: typo in function name
Problem: Typo in function name.
Solution: Rename the function. (closesvim/vim#10971)
5fb3aabc2b
Problem: Missing test coverage.
Solution: Improve test coverage for completion with different encodings,
mapset(), and term function failures. (Dominique Pellé,
closesvim/vim#7877)
a1070eae77
Cherry-pick E716 -> E715 change from patch 8.2.4861.
Problem: Reading past end of completion with a long line and 'infercase'
set.
Solution: Allocate the string if needed.
caea66442d
Cherry-pick the deletion of a blank line from patch 9.0.0027.
N/A patches for version.c:
vim-patch:9.0.0054: compiler warning for size_t to int conversion
Problem: Compiler warning for size_t to int conversion.
Solution: Add type cast. (Mike Williams, closesvim/vim#10741)
c7bd2f08e5
Previously if a highlight group with a name outside the regexp
[a-zA-Z0-9_] was defined, Nvim would emit an "invalid character"
warning message. This was annoying for Lua scripts, as it was very hard
to debug what line of code was triggering this message since it didn't
produce a stack trace.
This has now been promoted to an error with the code E5248.
Additionally the ASCII character period ('.') and at-sign ('@') have
been added to the allowed list of characters of a highlight group name
to support the application of defining hierarchical highlight groups,
e.g. 'TS.keyword'.
Co-authored-by: Christian Clason <christian.clason@uni-due.de>
In non-multigrid UI the only change is that the returned height now
excludes winbar, and this is compatible with Vim.
In multigrid UI this means the return value of these functions now
reflect the space available for buffer lines in a window.
No change in nvim_win_get_height() and nvim_win_get_width().
Problem: Insert completion code is too complicated.
Solution: More refactoring. Move function arguments into a struct.
(Yegappan Lakshmanan, closesvim/vim#9437)
6ad84ab3e4
Skip most pum-related refactoring.
Cherry-pick rename to match_at_original_text() from patch 8.2.4001.
Problem: Insert mode completion functions are too long.
Solution: Split up into multiple functions. (Yegappan Lakshmanan,
closesvim/vim#9431)
5d2e007ccb
Cherry-pick can_cindent_get() -> get_can_cindent() from patch 8.1.2062.
Problem: Insert mode completion function is too long.
Solution: Refactor into multiple functions. (Yegappan Lakshmanan,
closesvim/vim#9423)
edc6f10390
Cherry-pick a typo fix from patch 8.2.3637.
