Commit Graph

18117 Commits

Author SHA1 Message Date
James McCoy
efed75f916
coverity/331377: os_fopen: Remove invalid iflags assert
If the O_* flags were non-zero, then ORing the flags would always be
true.  However, the O_* flags aren't guaranteed to be non-zero, so the
assert is invalid in the first place.
2021-05-06 18:57:22 -04:00
James McCoy
d9eaca99be
coverity/331399: Remove unused "term_name" member from PtyProcess 2021-05-06 18:57:22 -04:00
James McCoy
d4fd139c2a
coverity/331366: fname_trans_sid: Avoid buffer overrun
Since we're printf()ing into an offset of fname_buf, we need to reduce
the max length by the same amount.
2021-05-06 18:57:21 -04:00
Michael Lingelbach
a3e914b64c
Merge pull request #14507 from fsouza/add-test-for-jumplist-fix
lsp: add a test for the jump_to_location + jump list fix
2021-05-06 15:57:10 -07:00
James McCoy
9bdbac6712
coverity/331382: Allocate enough space for trailing NUL 2021-05-06 18:56:57 -04:00
James McCoy
f6d4226f4d
coverity/188735: last_nonfloat: Ensure wp is non-NULL before dereferencing 2021-05-06 18:56:56 -04:00
James McCoy
833a6fcb60
coverity/331378: Fix inserting new decor provider
Since the providers are ordered by ns_id, inserting a new provider may
require shifting existing providers around to maintain this ordering.

When this happens, we need to allocate a new element at the end of the
vector and then shift the larger elements to the right.  Rather than
iterating (incorrectly) with a loop and copying each item, use memmove
to copy the entire block.
2021-05-06 18:56:56 -04:00
francisco souza
9149fe48a9 lsp: add a test for the jump_to_location + jump list fix 2021-05-06 17:56:24 -04:00
jing
1def3d1542 api/window: use the "noblock" variants in nvim_win_set_buf
after commit 92c6383cdca977("vim-patch:8.1.1425: win_execute() does not set window pointers properly"),
nvim_win_set_buf can use switch_win_noblock and restore_win_noblock.
It makes nvim_win_set_buf don't block autocmds so that it will be more
"without side-effects" as said in help text.

Signed-off-by: jing <lhchenjw@gmail.com>
2021-05-06 23:45:16 +08:00
jing
03b3ff8610 vim-patch:8.2.2340: win_execute() unexpectedly returns number zero when failing
Problem:    win_execute() unexpectedly returns number zero when failing.
Solution:   Return an empty string. (closes vim/vim#7665)
37487e16da
2021-05-06 23:45:16 +08:00
jing
8fecc5fab8 vim-patch:8.2.0137: crash when using win_execute() from a new tab
Problem:    Crash when using win_execute() from a new tab.
Solution:   Set the tp_*win pointers. (Ozaki Kiichi, closes vim/vim#5512)
a44b3eeafa
2021-05-06 23:45:16 +08:00
jing
ec3524da29 vim-patch:8.1.2124: ruler is not updated if win_execute() moves cursor
Problem:    Ruler is not updated if win_execute() moves cursor.
Solution:   Update the status line. (closes vim/vim#5022)
345f28df54
2021-05-06 23:45:16 +08:00
jing
73154bbae0 vim-patch:8.1.1832: win_execute() does not work in other tab
Problem:    Win_execute() does not work in other tab. (Rick Howe)
Solution:   Take care of the tab. (closes vim/vim#4792)
820680b9ff
2021-05-06 23:45:16 +08:00
jing
3c00252248 vim-patch:8.1.1440: win_execute() test fails
Problem:    Win_execute() test fails.
Solution:   Adjust the expected error number.  Move to popup test.
2d247849ce
2021-05-06 23:45:16 +08:00
jing
97abf8ee63 vim-patch:8.1.1425: win_execute() does not set window pointers properly
Problem:    Win_execute() does not set window pointers properly.
Solution:   Use switch_win_noblock().  Also execute autocommands in a popup
            window.
89adc3a137
2021-05-06 23:45:16 +08:00
jing
f6518e5516 vim-patch:8.1.1418: win_execute() is not implemented yet
Problem:    Win_execute() is not implemented yet.
Solution:   Implement it.
868b7b6712
2021-05-06 23:44:47 +08:00
Jan Edmund Lazo
71107e12c7
Merge pull request #14499 from janlazo/vim-8.2.2819
vim-patch:8.0.1309,8.2.{1166,2819,2820,2825,2827,2828,2829,2832,2833}
2021-05-06 09:00:24 -04:00
Jan Edmund Lazo
296711cfad
vim-patch:8.2.2829: some comments are not correct or clear
Problem:    Some comments are not correct or clear.
Solution:   Adjust the comments.  Add test for cursor position.
df36514a64
2021-05-06 00:55:30 -04:00
Jan Edmund Lazo
dad17caa87
lint 2021-05-06 00:42:20 -04:00
Jan Edmund Lazo
de299724cd
vim-patch:8.2.2833: two key command cancelled by moving mouse when using popup
Problem:    Two key command cancelled by moving mouse when using popup.
            (Sergey Vlasov)
Solution:   Ignore K_MOUSEMOVE in plain_vgetc().
3a00659db7
2021-05-06 00:32:35 -04:00
Jan Edmund Lazo
0be0f9895d
vim-patch:8.2.2832: operator cancelled by moving mouse when using popup
Problem:    Operator cancelled by moving mouse when using popup. (Sergey
            Vlasov)
Solution:   Do not trigger an operator for a mouse move events. (closes vim/vim#8176)
1ad72c8eb6
2021-05-06 00:31:18 -04:00
Jan Edmund Lazo
f70ecbd4dc
vim-patch:8.2.1166: once mouse move events are enabled getchar() returns them
Problem:    Once mouse move events are enabled getchar() returns them.
Solution:   Ignore K_MOUSEMOVE in getchar(). (closes vim/vim#6424)
ae97b94176
2021-05-06 00:26:37 -04:00
Jan Edmund Lazo
51403d6d41
vim-patch:8.0.1309: cannot use 'balloonexpr' in a terminal
Problem:    Cannot use 'balloonexpr' in a terminal.
Solution:   Add 'balloonevalterm' and add code to handle mouse movements in a
            terminal. Initial implementation for Unix with GUI.
51b0f3701e
2021-05-06 00:19:10 -04:00
Jan Edmund Lazo
4910ac9ab8
vim-patch:8.2.2828: Coverity complains about not checking rename() return value
Problem:    Coverity complains about not checking the rename() return value.
Solution:   Add "(void)", can't do anything in case of a failure.
97a6c6a1fb
2021-05-05 22:59:40 -04:00
Jan Edmund Lazo
5c6018ba2f
vim-patch:8.2.2827: test file was not deleted
Problem:    Test file was not deleted.
Solution:   Uncomment the delete() call. (Dominique Pellé, closes vim/vim#8172)
5f8ed7408a
2021-05-05 22:57:47 -04:00
Jan Edmund Lazo
7d2e76e333
vim-patch:8.2.2825: code in checkreadonly() not fully tested
Problem:    Code in checkreadonly() not fully tested.
Solution:   Add more tests. (Dominique Pellé, closes vim/vim#8169)
2bf6034e5c
2021-05-05 22:54:17 -04:00
Jan Edmund Lazo
44a331c36b
vim-patch:8.2.2820: session file may divide by zero
Problem:    Session file may divide by zero.
Solution:   Avoid writing difide by zero. (closes vim/vim#8162)
b6c2e9a010

Avoid typecasts if possible.
Use PRIdLINENR, PRId64, to format line numbers.
2021-05-05 22:50:57 -04:00
Jan Edmund Lazo
dd935e1473
vim-patch:8.2.2819: finishing an abbreviation with multi-byte char may not work
Problem:    Finishing an abbreviation with a multi-byte char may not work.
Solution:   Escape K_SPECIAL in the typed character. (closes vim/vim#8160)
4934ed34c3
2021-05-05 22:06:10 -04:00
James McCoy
8a93d1028f
Merge pull request #14497 from jamessan/ci-updates
ci(coverity): Fix typo in tar command
2021-05-05 12:55:17 -04:00
James McCoy
7ae1417ad5
ci(coverity): Fix typo in tar command
[skip ci]
2021-05-05 12:54:47 -04:00
James McCoy
554468cc03
Merge pull request #14493 from jamessan/ci-updates 2021-05-05 11:48:08 -04:00
James McCoy
3bebe60121
ci(gha): Run ci workflow for PRs into release branches 2021-05-05 09:21:12 -04:00
James McCoy
d399a853a3
Exclude .github/ and CI files from exported archives
These are only relevant for GitHub, not published tarballs.
2021-05-05 08:59:12 -04:00
James McCoy
26f5b979ec
ci(gha): Add weekly Coverity scans
[skip ci]
2021-05-05 08:54:03 -04:00
Björn Linse
7fcc596557
Merge pull request #14483 from mjlbach/floating_window_border_fix
window.c: fix floating window border width calculation
2021-05-05 07:09:04 +02:00
Björn Linse
1c2e504d5c
Merge pull request #14492 from seandewar/gcc-conv-warn
fix(gcc): compile warning in nvim_buf_set_extmark
2021-05-05 07:04:43 +02:00
Sean Dewar
b274b9887a
fix(gcc): compile warning in nvim_buf_set_extmark 2021-05-05 02:15:51 +01:00
Jan Edmund Lazo
4ad30f775e
Merge pull request #14424 from janlazo/vim-8.1.1726
vim-patch:8.1.1726,8.2.{296,860,1827,2388,2788,2790,2801}
2021-05-04 19:18:16 -04:00
Michael Lingelbach
ca058082ae tests: floating windows terminate border on edge of viewport when window extends past viewport 2021-05-04 15:43:53 -07:00
James McCoy
63d8a8f4e8
Merge pull request #14480 from mhinz/issue-template
template: make sure people read `:h vim-differences`
2021-05-04 09:38:08 -04:00
James McCoy
c2624b87cb
Merge pull request #14486 from Sh3Rm4n/fix_get_str_line
get_str_line: Replace grow_array usage
2021-05-04 09:37:25 -04:00
Jan Edmund Lazo
d5b063aec1
Revert vim-patch:942db23c9cb7 for phpcomplete.vim
It targets Vim 8.2 without feature and version checks.
2021-05-04 07:28:24 -04:00
Fabian Viöl
c9567704b7 get_str_line: Replace grow_array usage
A single xmemdupz is sufficient, as it is already
zero-terminating the string
2021-05-03 22:53:13 +02:00
Thomas Vigouroux
3fc71ea228
Merge pull request #14418 from DerekStride/treesitter-set-directive
[RDY] tree-sitter ensure there is a nested table allocated for `#set!`
2021-05-03 21:41:39 +02:00
Michael Lingelbach
d45e168a1d window.c: fix floating window border width calculation
* lift calculation of w_border_adj into win_config_float
* Check max floating window height and width against
  w_{height,width}_outer when positioning window
2021-05-03 00:29:49 -07:00
Michael Lingelbach
ad81144442
Merge pull request #14334 from DarwinSenior/vim.log
lsp: deep copy vim.lsp.log when reloading
2021-05-02 23:40:34 -07:00
James McCoy
0ee52fba31
ci(gha/ci): Use clang-12 for TSAN 2021-05-02 22:24:28 -04:00
James McCoy
a0da4c3a49
Merge pull request #14455 from Sh3Rm4n/fix_get_str_line
[RDY] Fix get str line
2021-05-02 16:47:36 -04:00
James McCoy
14c692bc82
ci(gha/release): Bump to ubuntu-18.04
Per https://wiki.ubuntu.com/Releases, 16.04 is no longer under standard
support.  Switch to the next LTS, 18.04, for the next couple years.
2021-05-02 16:27:37 -04:00
Michael Lingelbach
cfaf666ac9
Merge pull request #14462 from kabouzeid/feature/formatting_seq_sync
[LSP] Support for sequential formatting with multiple clients
2021-05-02 12:52:27 -07:00