From 06be5cde64779440b2c3d893f3f5d7212541e8bd Mon Sep 17 00:00:00 2001 From: Mark Wolters Date: Thu, 5 Oct 2023 15:51:57 -0400 Subject: [PATCH] no more log collection --- .github/workflows/build.yml | 20 +++++++++---------- .github/workflows/preview.yml | 14 ++++++------- .../io/nosqlbench/api/histo/HdrHistoLog.java | 2 ++ .../io/nosqlbench/api/histo/HistoStats.java | 1 + 4 files changed, 20 insertions(+), 17 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4c6ab21a6..1177173e1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -53,17 +53,17 @@ jobs: # name: codecov-report # path: codecov-report.tgz - - name: Collecting logfiles - if: success() || failure() - run: tar -zcvf logfiles.tgz [a-zA-Z]**/logs/* +# - name: Collecting logfiles +# if: success() || failure() +# run: tar -zcvf logfiles.tgz [a-zA-Z]**/logs/* - - name: Uploading log files - if: success() || failure() - uses: actions/upload-artifact@v3 - with: - node-version: '16' - name: nb-logs - path: logfiles.tgz +# - name: Uploading log files +# if: success() || failure() +# uses: actions/upload-artifact@v3 +# with: +# node-version: '16' +# name: nb-logs +# path: logfiles.tgz - name: export docs if: success() diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index d24be2d58..82f0b1fe8 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -191,13 +191,13 @@ jobs: # asset_name: nb5 # asset_content_type: application/octet-stream - - name: Archive Test Results - if: always() - uses: actions/upload-artifact@v3 - with: - name: test-results - path: | - [a-zA-Z]**/logs/* +# - name: Archive Test Results +# if: always() +# uses: actions/upload-artifact@v3 +# with: +# name: test-results +# path: | +# [a-zA-Z]**/logs/* # This triggers a preview build by cascading the tag to the builddocs repo. # The builddocs repo then pushes to preview or release depending on the tag. diff --git a/nb-api/src/main/java/io/nosqlbench/api/histo/HdrHistoLog.java b/nb-api/src/main/java/io/nosqlbench/api/histo/HdrHistoLog.java index 3b5d160e3..e357a7ddd 100644 --- a/nb-api/src/main/java/io/nosqlbench/api/histo/HdrHistoLog.java +++ b/nb-api/src/main/java/io/nosqlbench/api/histo/HdrHistoLog.java @@ -43,5 +43,7 @@ public class HdrHistoLog extends NBBaseComponent { HistoIntervalLogger histoIntervalLogger = new HistoIntervalLogger(this, session, logfile, compiledPattern, intervalMillis); this.attachChild(histoIntervalLogger); + + //TODO: Use create().histogram() instead? } } diff --git a/nb-api/src/main/java/io/nosqlbench/api/histo/HistoStats.java b/nb-api/src/main/java/io/nosqlbench/api/histo/HistoStats.java index a9cbda6b5..fd57714ff 100644 --- a/nb-api/src/main/java/io/nosqlbench/api/histo/HistoStats.java +++ b/nb-api/src/main/java/io/nosqlbench/api/histo/HistoStats.java @@ -45,5 +45,6 @@ public class HistoStats extends NBBaseComponent { HistoStatsLogger histoStatsLogger = new HistoStatsLogger(this, sessionComment, logfile, compiledPattern, intervalMillis, TimeUnit.NANOSECONDS); this.attachChild(histoStatsLogger); + //TODO: Use create().histogram() instead? } }