Pulsar: add bytes counter

This commit is contained in:
Enrico Olivelli 2021-03-22 17:49:07 +01:00
parent 001ba616a3
commit 0f53ea63a2
5 changed files with 33 additions and 10 deletions

View File

@ -27,7 +27,7 @@
<dependency> <dependency>
<groupId>org.apache.pulsar</groupId> <groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-client</artifactId> <artifactId>pulsar-client-original</artifactId>
<version>${pulsar.version}</version> <version>${pulsar.version}</version>
</dependency> </dependency>
@ -75,7 +75,7 @@
<dependency> <dependency>
<groupId>org.apache.avro</groupId> <groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId> <artifactId>avro</artifactId>
<version>1.10.1</version> <version>1.9.1</version>
</dependency> </dependency>
</dependencies> </dependencies>

View File

@ -1,5 +1,7 @@
package io.nosqlbench.driver.pulsar; package io.nosqlbench.driver.pulsar;
import com.codahale.metrics.Counter;
import com.codahale.metrics.Meter;
import com.codahale.metrics.Timer; import com.codahale.metrics.Timer;
import io.nosqlbench.driver.pulsar.ops.PulsarOp; import io.nosqlbench.driver.pulsar.ops.PulsarOp;
import io.nosqlbench.driver.pulsar.ops.ReadyPulsarOp; import io.nosqlbench.driver.pulsar.ops.ReadyPulsarOp;
@ -20,6 +22,7 @@ public class PulsarActivity extends SimpleActivity implements ActivityDefObserve
public Timer bindTimer; public Timer bindTimer;
public Timer executeTimer; public Timer executeTimer;
public Counter bytesCounter;
private PulsarSpaceCache pulsarCache; private PulsarSpaceCache pulsarCache;
private PulsarNBClientConf clientConf; private PulsarNBClientConf clientConf;
@ -41,6 +44,7 @@ public class PulsarActivity extends SimpleActivity implements ActivityDefObserve
bindTimer = ActivityMetrics.timer(activityDef, "bind"); bindTimer = ActivityMetrics.timer(activityDef, "bind");
executeTimer = ActivityMetrics.timer(activityDef, "execute"); executeTimer = ActivityMetrics.timer(activityDef, "execute");
bytesCounter = ActivityMetrics.counter(activityDef, "bytes");
String pulsarClntConfFile = activityDef.getParams().getOptionalString("config").orElse("config.properties"); String pulsarClntConfFile = activityDef.getParams().getOptionalString("config").orElse("config.properties");
clientConf = new PulsarNBClientConf(pulsarClntConfFile); clientConf = new PulsarNBClientConf(pulsarClntConfFile);
@ -49,7 +53,7 @@ public class PulsarActivity extends SimpleActivity implements ActivityDefObserve
pulsarCache = new PulsarSpaceCache(this); pulsarCache = new PulsarSpaceCache(this);
this.sequencer = createOpSequence((ot) -> new ReadyPulsarOp(ot, pulsarCache)); this.sequencer = createOpSequence((ot) -> new ReadyPulsarOp(ot, pulsarCache, this));
setDefaultsFromOpSequence(sequencer); setDefaultsFromOpSequence(sequencer);
onActivityDefUpdate(activityDef); onActivityDefUpdate(activityDef);
@ -87,4 +91,8 @@ public class PulsarActivity extends SimpleActivity implements ActivityDefObserve
public Timer getExecuteTimer() { public Timer getExecuteTimer() {
return this.executeTimer; return this.executeTimer;
} }
public Counter getBytesCounter() {
return bytesCounter;
}
} }

View File

@ -1,5 +1,6 @@
package io.nosqlbench.driver.pulsar.ops; package io.nosqlbench.driver.pulsar.ops;
import com.codahale.metrics.Counter;
import io.nosqlbench.driver.pulsar.PulsarSpace; import io.nosqlbench.driver.pulsar.PulsarSpace;
import io.nosqlbench.engine.api.templating.CommandTemplate; import io.nosqlbench.engine.api.templating.CommandTemplate;
import org.apache.pulsar.client.api.Producer; import org.apache.pulsar.client.api.Producer;
@ -22,18 +23,21 @@ public class PulsarProducerMapper extends PulsarOpMapper {
private final LongFunction<Boolean> asyncApiFunc; private final LongFunction<Boolean> asyncApiFunc;
private final LongFunction<String> keyFunc; private final LongFunction<String> keyFunc;
private final LongFunction<String> payloadFunc; private final LongFunction<String> payloadFunc;
private final Counter bytesCounter;
public PulsarProducerMapper(CommandTemplate cmdTpl, public PulsarProducerMapper(CommandTemplate cmdTpl,
PulsarSpace clientSpace, PulsarSpace clientSpace,
LongFunction<Producer<?>> producerFunc, LongFunction<Producer<?>> producerFunc,
LongFunction<Boolean> asyncApiFunc, LongFunction<Boolean> asyncApiFunc,
LongFunction<String> keyFunc, LongFunction<String> keyFunc,
LongFunction<String> payloadFunc) { LongFunction<String> payloadFunc,
Counter bytesCounter) {
super(cmdTpl, clientSpace); super(cmdTpl, clientSpace);
this.producerFunc = producerFunc; this.producerFunc = producerFunc;
this.asyncApiFunc = asyncApiFunc; this.asyncApiFunc = asyncApiFunc;
this.keyFunc = keyFunc; this.keyFunc = keyFunc;
this.payloadFunc = payloadFunc; this.payloadFunc = payloadFunc;
this.bytesCounter = bytesCounter;
} }
@Override @Override
@ -48,6 +52,7 @@ public class PulsarProducerMapper extends PulsarOpMapper {
clientSpace.getPulsarSchema(), clientSpace.getPulsarSchema(),
asyncApi, asyncApi,
msgKey, msgKey,
msgPayload); msgPayload,
bytesCounter);
} }
} }

View File

@ -1,6 +1,6 @@
package io.nosqlbench.driver.pulsar.ops; package io.nosqlbench.driver.pulsar.ops;
import io.nosqlbench.driver.pulsar.PulsarAction; import com.codahale.metrics.Counter;
import io.nosqlbench.driver.pulsar.util.AvroUtil; import io.nosqlbench.driver.pulsar.util.AvroUtil;
import io.nosqlbench.driver.pulsar.util.PulsarActivityUtil; import io.nosqlbench.driver.pulsar.util.PulsarActivityUtil;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
@ -22,17 +22,20 @@ public class PulsarProducerOp implements PulsarOp {
private final String msgKey; private final String msgKey;
private final String msgPayload; private final String msgPayload;
private final boolean asyncPulsarOp; private final boolean asyncPulsarOp;
private final Counter bytesCounter;
public PulsarProducerOp(Producer<?> producer, public PulsarProducerOp(Producer<?> producer,
Schema<?> schema, Schema<?> schema,
boolean asyncPulsarOp, boolean asyncPulsarOp,
String key, String key,
String payload) { String payload,
Counter bytesCounter) {
this.producer = producer; this.producer = producer;
this.pulsarSchema = schema; this.pulsarSchema = schema;
this.msgKey = key; this.msgKey = key;
this.msgPayload = payload; this.msgPayload = payload;
this.asyncPulsarOp = asyncPulsarOp; this.asyncPulsarOp = asyncPulsarOp;
this.bytesCounter = bytesCounter;
} }
@Override @Override
@ -54,8 +57,12 @@ public class PulsarProducerOp implements PulsarOp {
msgPayload msgPayload
); );
typedMessageBuilder = typedMessageBuilder.value(payload); typedMessageBuilder = typedMessageBuilder.value(payload);
// TODO: add a way to calculate the message size for AVRO messages
bytesCounter.inc(msgPayload.length());
} else { } else {
typedMessageBuilder = typedMessageBuilder.value(msgPayload.getBytes(StandardCharsets.UTF_8)); byte[] array = msgPayload.getBytes(StandardCharsets.UTF_8);
typedMessageBuilder = typedMessageBuilder.value(array);
bytesCounter.inc(array.length);
} }
//TODO: add error handling with failed message production //TODO: add error handling with failed message production

View File

@ -20,11 +20,13 @@ public class ReadyPulsarOp implements OpDispenser<PulsarOp> {
private final CommandTemplate cmdTpl; private final CommandTemplate cmdTpl;
private final PulsarSpace clientSpace; private final PulsarSpace clientSpace;
private final LongFunction<PulsarOp> opFunc; private final LongFunction<PulsarOp> opFunc;
private final PulsarActivity pulsarActivity;
// TODO: Add docs for the command template with respect to the OpTemplate // TODO: Add docs for the command template with respect to the OpTemplate
public ReadyPulsarOp(OpTemplate opTemplate, PulsarSpaceCache pcache) { public ReadyPulsarOp(OpTemplate opTemplate, PulsarSpaceCache pcache, PulsarActivity pulsarActivity) {
// TODO: Consider parsing map structures into equivalent binding representation // TODO: Consider parsing map structures into equivalent binding representation
this.pulsarActivity = pulsarActivity;
this.opTpl = opTemplate; this.opTpl = opTemplate;
this.cmdTpl = new CommandTemplate(opTemplate); this.cmdTpl = new CommandTemplate(opTemplate);
@ -180,7 +182,8 @@ public class ReadyPulsarOp implements OpDispenser<PulsarOp> {
producerFunc, producerFunc,
async_api_func, async_api_func,
keyFunc, keyFunc,
valueFunc); valueFunc,
pulsarActivity.getBytesCounter());
} }
private LongFunction<PulsarOp> resolveMsgConsume( private LongFunction<PulsarOp> resolveMsgConsume(