From 1025b1ddc2a73b54274d8cd07fbb8e9c6f113d8d Mon Sep 17 00:00:00 2001
From: yabinmeng <yabinmeng@gmail.com>
Date: Wed, 1 May 2024 20:24:51 -0500
Subject: [PATCH] Add a warning message for invalid input compression type
 string

---
 .../adapter/s4j/util/S4JClientConfConverter.java         | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/nb-adapters/adapter-s4j/src/main/java/io/nosqlbench/adapter/s4j/util/S4JClientConfConverter.java b/nb-adapters/adapter-s4j/src/main/java/io/nosqlbench/adapter/s4j/util/S4JClientConfConverter.java
index 7b4e0adfc..f9908c527 100644
--- a/nb-adapters/adapter-s4j/src/main/java/io/nosqlbench/adapter/s4j/util/S4JClientConfConverter.java
+++ b/nb-adapters/adapter-s4j/src/main/java/io/nosqlbench/adapter/s4j/util/S4JClientConfConverter.java
@@ -22,6 +22,8 @@ import com.fasterxml.jackson.databind.ObjectMapper;
 import io.nosqlbench.adapter.s4j.exception.S4JAdapterInvalidParamException;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.math.NumberUtils;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -35,6 +37,8 @@ import java.util.Map;
  */
 public class S4JClientConfConverter {
 
+    private final static Logger logger = LogManager.getLogger(S4JClientConfConverter.class);
+
     public static Map<String, Object> convertRawClientConf(Map<String, String> pulsarClientConfMapRaw) {
         Map<String, Object> s4jClientConfObjMap = new HashMap<>();
         s4jClientConfObjMap.putAll(pulsarClientConfMapRaw);
@@ -87,6 +91,11 @@ public class S4JClientConfConverter {
                 };
             } catch (IllegalArgumentException e) {
                 // Any invalid value will be treated as no compression
+                logger.warn("Invalid producer \"compressionType\" value ({}) in the config properties file. " +
+                    "Expecting one of the following values: {}. " +
+                    "No message compression will be applied (for producers).",
+                    confVal,
+                    S4JAdapterUtil.getValidMsgCompressionTypeList());
             }
         }