either log or throw, but not both

driver-cql-shaded/src/main/java/io/nosqlbench/activitytype/cql/statements/binders/UnsettableValuesBinder.java

@@ -46,7 +46,7 @@ public class UnsettableValuesBinder implements ValuesArrayBinder<PreparedStateme
             return boundStmt;
         } catch (Exception e) {
             String typNam = (objects[i]==null ? "NULL" : objects[i].getClass().getCanonicalName());
-            logger.error("Error binding column " + preparedStatement.getVariables().asList().get(i).getName() + " with class " + typNam + ": " + e.getMessage(), e);
+            logger.error("Error binding column " + preparedStatement.getVariables().asList().get(i).getName() + " with class " + typNam, e);
             throw e;
 //            StringBuilder sb = new StringBuilder();
 //            sb.append("Error binding objects to prepared statement directly, falling back to diagnostic binding layer:");

driver-cql-shaded/src/main/java/io/nosqlbench/activitytype/cql/statements/core/CQLSessionCache.java

@@ -154,8 +154,7 @@ public class CQLSessionCache implements Shutdownable {
                 builder = clusterEval.eval();
                 logger.info("successfully applied:" + clusteropts.get());
             } catch (Exception e) {
-                logger.error("Unable to evaluate: " + clusteropts.get() + " in script context:" + e.getMessage());
+                throw new RuntimeException("Unable to evaluate: " + clusteropts.get() + " in script context:",e);
-                throw e;
             }
         }
 

driver-cql-shaded/src/main/java/io/nosqlbench/activitytype/cql/statements/core/YamlCQLStatementLoader.java

@@ -42,7 +42,6 @@ public class YamlCQLStatementLoader {
                 data = xform.apply(data);
             } catch (Exception e) {
                 RuntimeException t = new ActivityInitializationError("Error applying string transform to input", e);
-                logger.error(t.getMessage(), t);
                 throw t;
             }
         }

driver-cql-shaded/src/main/java/io/nosqlbench/activitytype/cql/statements/rowoperators/Save.java

@@ -38,7 +38,7 @@ public class Save implements RowCycleOperator {
             List<ColumnDefinitions.Definition> definitions = row.getColumnDefinitions().asList();
             logger.error("Unable to save '" + Arrays.toString(varnames) + "' from " +
                     definitions.stream().map(ColumnDefinitions.Definition::getName)
-            .collect(Collectors.joining(",","[","]")) + ": " + e.getMessage(),e);
+            .collect(Collectors.joining(",","[","]")) + ": ",e);
             throw e;
         }
         return 0;

driver-cqld4/src/main/java/io/nosqlbench/activitytype/cqld4/statements/binders/UnsettableValuesBinder.java

@@ -58,7 +58,7 @@ public class UnsettableValuesBinder implements ValuesArrayBinder<PreparedStateme
             List<ColumnDefinition> cdefs = new ArrayList<>();
             preparedStatement.getVariableDefinitions().forEach(cdefs::add);
 
-            logger.error("Error binding column " + cdefs.get(i).getName() + " with class " + typNam + ": " + e.getMessage(), e);
+            logger.error("Error binding column " + cdefs.get(i).getName() + " with class " + typNam, e);
             throw e;
 //            StringBuilder sb = new StringBuilder();
 //            sb.append("Error binding objects to prepared statement directly, falling back to diagnostic binding layer:");

driver-cqld4/src/main/java/io/nosqlbench/activitytype/cqld4/statements/core/YamlCQLStatementLoader.java

@@ -38,7 +38,6 @@ public class YamlCQLStatementLoader {
                 data = xform.apply(data);
             } catch (Exception e) {
                 RuntimeException t = new ActivityInitializationError("Error applying string transform to input", e);
-                logger.error(t.getMessage(), t);
                 throw t;
             }
         }

engine-api/src/main/java/io/nosqlbench/engine/api/activityconfig/rawyaml/RawStmtsLoader.java

@@ -28,7 +28,6 @@ public class RawStmtsLoader {
             }
         } catch (Exception e) {
             RuntimeException t = new ActivityInitializationError("Error applying string applyTransforms to input", e);
-            if (logger != null) logger.error(t.getMessage(), t);
             throw t;
         }
 
@@ -76,7 +75,6 @@ public class RawStmtsLoader {
                 data = xform.apply(data);
             } catch (Exception e) {
                 RuntimeException t = new ActivityInitializationError("Error applying string applyTransforms to input", e);
-                if (logger != null) logger.error(t.getMessage(), t);
                 throw t;
             }
         }

engine-api/src/main/java/io/nosqlbench/engine/api/metrics/HistoStatsCSVWriter.java

@@ -45,7 +45,6 @@ public class HistoStatsCSVWriter {
             PrintStream writer = new PrintStream(logfile);
             return writer;
         } catch (IOException e) {
-            logger.error(e.getMessage(), e);
             throw new RuntimeException(e);
         }
     }

nb-api/src/main/java/io/nosqlbench/nb/api/content/PathFinder.java

@@ -102,7 +102,7 @@ public class PathFinder {
             }
             return Optional.empty();
         } catch (Exception e) {
-            logger.trace("Error while looking in classpath for " + e.getMessage(), e);
+            logger.trace("Error while looking in classpath for " + candidatePath, e);
             return Optional.empty();
         }
     }

virtdata-userlibs/src/main/java/io/nosqlbench/virtdata/userlibs/apps/valuesapp/ValuesCheckerCoordinator.java

@@ -188,7 +188,7 @@ public class ValuesCheckerCoordinator implements Callable<RunData> {
             lock.lock();
             goTime.signalAll();
         } catch (Exception e) {
-            logger.error("Error while signaling threads: " + e.getMessage(), e);
+            logger.error("Error while signaling threads:", e);
             throw new RuntimeException(e);
         } finally {
             lock.unlock();