Address Lari's comment in PR#364.

This commit is contained in:
Yabin Meng 2021-10-06 11:41:50 -05:00
parent eb5f42f46d
commit 265760d184

View File

@ -12,7 +12,6 @@ import org.apache.commons.lang3.StringUtils;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.pulsar.client.admin.PulsarAdmin;
import org.apache.pulsar.client.admin.PulsarAdminException;
import org.apache.pulsar.client.api.Producer;
import org.apache.pulsar.client.api.Consumer;
import org.apache.pulsar.client.api.Reader;
@ -459,7 +458,8 @@ public class ReadyPulsarOp implements OpDispenser<PulsarOp> {
// - default to broker level deduplication setting
boolean nsMsgDedup = brokerMsgDupFunc.apply(l);
try {
nsMsgDedup = pulsarAdmin.namespaces().getDeduplicationStatus(namespace);
Boolean dedupStatus = pulsarAdmin.namespaces().getDeduplicationStatus(namespace);
if (dedupStatus != null) nsMsgDedup = dedupStatus;
}
catch (Exception e) {
// it is fine if we're unable to check namespace level setting; use default
@ -469,7 +469,8 @@ public class ReadyPulsarOp implements OpDispenser<PulsarOp> {
// - default to namespace level deduplication setting
boolean topicMsgDedup = nsMsgDedup;
try {
topicMsgDedup = pulsarAdmin.topics().getDeduplicationStatus(topic);
Boolean dedupStatus = pulsarAdmin.topics().getDeduplicationStatus(namespace);
if (dedupStatus != null) topicMsgDedup = dedupStatus;
}
catch (Exception e) {
// it is fine if we're unable to check topic level setting; use default