IntenseFinance/nosqlbench
3
0
Fork 0
mirror of https://github.com/nosqlbench/nosqlbench.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

add notes for improvements

Browse Source
This commit is contained in:
Jonathan Shook 2023-12-19 10:12:24 -06:00
parent 4e9963ab17
commit 3346cd2624
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine-core/src/main/java/io/nosqlbench/engine/core/lifecycle/session/NBCommandAssembly.java
View File

@ -77,6 +77,8 @@ public class NBCommandAssembly {
throw new BasicError("Found zero commands for spec;" + cmd); throw new BasicError("Found zero commands for spec;" + cmd);
} }
String containerName = cmd.getTargetContext(); String containerName = cmd.getTargetContext();
// TODO, make this unnecessary by moving the impl out of the map to a dedicated cmd structure
params.remove("_impl"); params.remove("_impl");
parameterizedInvocations.add(new CommandInvocation(command, params, containerName)); parameterizedInvocations.add(new CommandInvocation(command, params, containerName));
} }

3
nbr/src/main/java/io/nosqlbench/scenarios/simframe/stabilization/StabilityDetector.java
View File

@ -155,6 +155,9 @@ public class StabilityDetector implements Runnable {
} }
} }
// TODO: Add a check for when stddev is lower than some fixed value, or when both
// (or all) windows are below some small threshold
// and perhaps add auto-correlation checks for (any of) style unblocking
private void updateAndAwait() { private void updateAndAwait() {
int interval = (int) (this.timeSliceSeconds * 1000); int interval = (int) (this.timeSliceSeconds * 1000);
startedAt = System.currentTimeMillis(); startedAt = System.currentTimeMillis();