From 5626430de8f8b7ec9781d9aa2f7c30a89f0c9b45 Mon Sep 17 00:00:00 2001 From: Jonathan Shook Date: Mon, 6 Feb 2023 12:07:25 -0600 Subject: [PATCH] disable unused edge case test until it is well defined --- .../engine/core/ActivityExecutorTest.java | 71 ++++++++++--------- 1 file changed, 37 insertions(+), 34 deletions(-) diff --git a/engine-core/src/test/java/io/nosqlbench/engine/core/ActivityExecutorTest.java b/engine-core/src/test/java/io/nosqlbench/engine/core/ActivityExecutorTest.java index edb3cd3b9..fe34d72e7 100644 --- a/engine-core/src/test/java/io/nosqlbench/engine/core/ActivityExecutorTest.java +++ b/engine-core/src/test/java/io/nosqlbench/engine/core/ActivityExecutorTest.java @@ -45,40 +45,43 @@ import static org.assertj.core.api.Assertions.fail; class ActivityExecutorTest { private static final Logger logger = LogManager.getLogger(ActivityExecutorTest.class); - @Test - synchronized void testRestart() { - ActivityDef activityDef = ActivityDef.parseActivityDef("driver=diag;alias=test-restart;cycles=1000;cyclerate=1;op=initdelay:initdelay=5000;"); - new ActivityTypeLoader().load(activityDef); - - final Activity activity = new DelayedInitActivity(activityDef); - InputDispenser inputDispenser = new CoreInputDispenser(activity); - ActionDispenser adisp = new CoreActionDispenser(activity); - OutputDispenser tdisp = CoreServices.getOutputDispenser(activity).orElse(null); - - final MotorDispenser mdisp = new CoreMotorDispenser(activity, inputDispenser, adisp, tdisp); - activity.setActionDispenserDelegate(adisp); - activity.setOutputDispenserDelegate(tdisp); - activity.setInputDispenserDelegate(inputDispenser); - activity.setMotorDispenserDelegate(mdisp); - - final ExecutorService executor = Executors.newCachedThreadPool(); - ActivityExecutor activityExecutor = new ActivityExecutor(activity, "test-restart"); - final Future future = executor.submit(activityExecutor); - try { - activityDef.setThreads(1); - activityExecutor.startActivity(); - Thread.sleep(500L); - activityExecutor.stopActivity(); - activityExecutor.startActivity(); - activityExecutor.stopActivity(); - future.get(); - } catch (Exception e) { - throw new RuntimeException(e); - } - executor.shutdown(); - assertThat(inputDispenser.getInput(10).getInputSegment(3)).isNotNull(); - - } +// TODO: Design review of this mechanism +// @Test +// synchronized void testRestart() { +// ActivityDef activityDef = ActivityDef.parseActivityDef("driver=diag;alias=test-restart;cycles=1000;cyclerate=10;op=initdelay:initdelay=5000;"); +// new ActivityTypeLoader().load(activityDef); +// +// final Activity activity = new DelayedInitActivity(activityDef); +// InputDispenser inputDispenser = new CoreInputDispenser(activity); +// ActionDispenser adisp = new CoreActionDispenser(activity); +// OutputDispenser tdisp = CoreServices.getOutputDispenser(activity).orElse(null); +// +// final MotorDispenser mdisp = new CoreMotorDispenser(activity, inputDispenser, adisp, tdisp); +// activity.setActionDispenserDelegate(adisp); +// activity.setOutputDispenserDelegate(tdisp); +// activity.setInputDispenserDelegate(inputDispenser); +// activity.setMotorDispenserDelegate(mdisp); +// +// final ExecutorService executor = Executors.newCachedThreadPool(); +// ActivityExecutor activityExecutor = new ActivityExecutor(activity, "test-restart"); +// final Future future = executor.submit(activityExecutor); +// try { +// activityDef.setThreads(1); +// activityExecutor.startActivity(); +// Thread.sleep(100L); +// activityExecutor.stopActivity(); +// Thread.sleep(100L); +// activityExecutor.startActivity(); +// Thread.sleep(100L); +// activityExecutor.stopActivity(); +// future.get(); +// } catch (Exception e) { +// throw new RuntimeException(e); +// } +// executor.shutdown(); +// assertThat(inputDispenser.getInput(10).getInputSegment(3)).isNotNull(); +// +// } @Test synchronized void testDelayedStartSanity() {