From 753c945a324be4cf707849878577fcc6b7d2fb7b Mon Sep 17 00:00:00 2001 From: Mark Wolters Date: Tue, 23 May 2023 19:56:44 +0000 Subject: [PATCH] updated ops to only log to debug on success --- .../opdispensers/PineconeDeleteOpDispenser.java | 5 ++--- .../PineconeDescribeIndexStatsOpDispenser.java | 3 ++- .../opdispensers/PineconeFetchOpDispenser.java | 3 ++- .../adapter/pinecone/ops/PineconeDeleteOp.java | 2 +- .../pinecone/ops/PineconeDescribeIndexStatsOp.java | 10 +++++++++- .../adapter/pinecone/ops/PineconeFetchOp.java | 9 ++++++++- .../adapter/pinecone/ops/PineconeQueryOp.java | 11 +++++++++-- .../adapter/pinecone/ops/PineconeUpdateOp.java | 2 +- .../adapter/pinecone/ops/PineconeUpsertOp.java | 2 +- 9 files changed, 35 insertions(+), 12 deletions(-) diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDeleteOpDispenser.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDeleteOpDispenser.java index 1c48efd23..101e06fd5 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDeleteOpDispenser.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDeleteOpDispenser.java @@ -53,9 +53,8 @@ public class PineconeDeleteOpDispenser extends PineconeOpDispenser { @Override public PineconeOp apply(long value) { - return new PineconeDeleteOp(pcFunction - .apply(value) - .getConnection(targetFunction.apply(value)), + return new PineconeDeleteOp(pcFunction.apply(value) + .getConnection(targetFunction.apply(value)), deleteRequestFunc.apply(value)); } diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDescribeIndexStatsOpDispenser.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDescribeIndexStatsOpDispenser.java index 22a4fc636..15d0ee17f 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDescribeIndexStatsOpDispenser.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDescribeIndexStatsOpDispenser.java @@ -70,7 +70,8 @@ public class PineconeDescribeIndexStatsOpDispenser extends PineconeOpDispenser { @Override public PineconeOp apply(long value) { - return new PineconeDescribeIndexStatsOp(pcFunction.apply(value).getConnection(targetFunction.apply(value)), + return new PineconeDescribeIndexStatsOp(pcFunction.apply(value) + .getConnection(targetFunction.apply(value)), indexStatsRequestFunc.apply(value)); } } diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeFetchOpDispenser.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeFetchOpDispenser.java index dcf15559d..0b75b3367 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeFetchOpDispenser.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeFetchOpDispenser.java @@ -77,7 +77,8 @@ public class PineconeFetchOpDispenser extends PineconeOpDispenser { @Override public PineconeOp apply(long value) { - return new PineconeFetchOp(pcFunction.apply(value).getConnection(targetFunction.apply(value)), + return new PineconeFetchOp(pcFunction.apply(value) + .getConnection(targetFunction.apply(value)), fetchRequestFunc.apply(value)); } } diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDeleteOp.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDeleteOp.java index 3f6f2083f..dedf2dd96 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDeleteOp.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDeleteOp.java @@ -44,7 +44,7 @@ public class PineconeDeleteOp extends PineconeOp { public void run() { try { DeleteResponse response = connection.getBlockingStub().delete(request); - logger.info(response.toString()); + logger.debug("Pincecone delete request successful: " + response.toString()); } catch (Exception e) { logger.error("Exception %s caught trying to do delete", e.getMessage()); logger.error(e.getStackTrace()); diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDescribeIndexStatsOp.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDescribeIndexStatsOp.java index 2e9b37dae..6861ead21 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDescribeIndexStatsOp.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDescribeIndexStatsOp.java @@ -20,9 +20,12 @@ import io.nosqlbench.engine.api.templating.ParsedOp; import io.pinecone.proto.DescribeIndexStatsRequest; import io.pinecone.proto.DescribeIndexStatsResponse; import io.pinecone.PineconeConnection; +import io.pinecone.proto.NamespaceSummary; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; +import java.util.Map; + public class PineconeDescribeIndexStatsOp extends PineconeOp { private static final Logger logger = LogManager.getLogger(PineconeDescribeIndexStatsOp.class); @@ -44,7 +47,12 @@ public class PineconeDescribeIndexStatsOp extends PineconeOp { public void run() { try { DescribeIndexStatsResponse response = connection.getBlockingStub().describeIndexStats(request); - // Do soemething with the response... + if (logger.isDebugEnabled()) { + logger.debug("Vector counts:"); + for (Map.Entry namespace : response.getNamespacesMap().entrySet()) { + logger.debug(namespace.getKey() + ": " + namespace.getValue().getVectorCount()); + } + } } catch (Exception e) { logger.error("Exception %s caught trying to do DescribeIndexStats", e.getMessage()); logger.error(e.getStackTrace()); diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeFetchOp.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeFetchOp.java index eb33ff0f3..8f19b84e4 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeFetchOp.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeFetchOp.java @@ -20,9 +20,12 @@ import io.nosqlbench.engine.api.templating.ParsedOp; import io.pinecone.proto.FetchRequest; import io.pinecone.PineconeConnection; import io.pinecone.proto.FetchResponse; +import io.pinecone.proto.Vector; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; +import java.util.Map; + public class PineconeFetchOp extends PineconeOp { private static final Logger logger = LogManager.getLogger(PineconeFetchOp.class); @@ -44,7 +47,11 @@ public class PineconeFetchOp extends PineconeOp { public void run() { try { FetchResponse response = connection.getBlockingStub().fetch(request); - // Do soemething with the response... + if (logger.isDebugEnabled()) { + for (Map.Entry vectors: response.getVectorsMap().entrySet()) { + logger.debug(vectors.getKey() + ": " + vectors.getValue().toString()); + } + } } catch (Exception e) { logger.error("Exception %s caught trying to do Fetch", e.getMessage()); logger.error(e.getStackTrace()); diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeQueryOp.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeQueryOp.java index 76f4a4230..ae35c0d39 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeQueryOp.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeQueryOp.java @@ -20,6 +20,8 @@ import io.nosqlbench.engine.api.templating.ParsedOp; import io.pinecone.proto.QueryRequest; import io.pinecone.PineconeConnection; import io.pinecone.proto.QueryResponse; +import io.pinecone.proto.ScoredVector; +import io.pinecone.proto.SingleQueryResults; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -44,8 +46,13 @@ public class PineconeQueryOp extends PineconeOp { public void run() { try { QueryResponse response = connection.getBlockingStub().query(request); - logger.info("got query result ids: " - + response.getResultsList().get(0).getMatchesList()); + if (logger.isDebugEnabled()) { + for (SingleQueryResults results : response.getResultsList()) { + for (ScoredVector scored : results.getMatchesList()) { + logger.debug(scored.getId() + ": " + scored.getScore()); + } + } + } } catch (Exception e) { logger.error("Exception %s caught trying to do Query", e.getMessage()); logger.error(e.getStackTrace()); diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeUpdateOp.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeUpdateOp.java index 815199b79..e1f37ac0e 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeUpdateOp.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeUpdateOp.java @@ -44,7 +44,7 @@ public class PineconeUpdateOp extends PineconeOp { public void run() { try { UpdateResponse response = connection.getBlockingStub().update(request); - // Do soemething with the response... + logger.debug("UpdateResponse succesful: " + response.toString()); } catch (Exception e) { logger.error("Exception %s caught trying to do Update", e.getMessage()); logger.error(e.getStackTrace()); diff --git a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeUpsertOp.java b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeUpsertOp.java index a932e3721..ec4258003 100644 --- a/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeUpsertOp.java +++ b/adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeUpsertOp.java @@ -44,7 +44,7 @@ public class PineconeUpsertOp extends PineconeOp { public void run() { try { UpsertResponse response = connection.getBlockingStub().upsert(request); - logger.info("Put " + response.getUpsertedCount() + " vectors into the index"); + logger.debug("Put " + response.getUpsertedCount() + " vectors into the index"); } catch (Exception e) { logger.error("Exception %s caught trying to do upsert", e.getMessage()); logger.error(e.getStackTrace());