IntenseFinance/nosqlbench
3
0
Fork 0
mirror of https://github.com/nosqlbench/nosqlbench.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

minor updates, notes collected into gh issues

Browse Source
This commit is contained in:
Jonathan Shook
2023-10-06 17:08:21 -05:00
parent bf2b16bbe3
commit 7be8fd0708
5 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
engine-cli/src/main/java/io/nosqlbench/engine/cli/NBCLI.java
View File

@@ -242,10 +242,6 @@ public class NBCLI implements Function<String[], Integer>, NBLabeledElement {
NBIO.addGlobalIncludes(options.wantsIncludes()); NBIO.addGlobalIncludes(options.wantsIncludes());
// TODO: metrics
// ActivityMetrics.setHdrDigits(options.getHdrDigits());
// ActivityMetrics.setLabelValidator(options.getAnnotateLabelSpec());
if (options.wantsBasicHelp()) { if (options.wantsBasicHelp()) {
System.out.println(this.loadHelpFile("basic.md")); System.out.println(this.loadHelpFile("basic.md"));
return NBCLI.EXIT_OK; return NBCLI.EXIT_OK;
@@ -366,7 +362,6 @@ public class NBCLI implements Function<String[], Integer>, NBLabeledElement {
.build() .build()
); );
// TODO: metrics
// if ((null != reportPromPushTo) || (null != reportGraphiteTo) || (null != options.wantsReportCsvTo())) { // if ((null != reportPromPushTo) || (null != reportGraphiteTo) || (null != options.wantsReportCsvTo())) {
// final MetricReporters reporters = MetricReporters.getInstance(); // final MetricReporters reporters = MetricReporters.getInstance();
// reporters.addRegistry("workloads", ActivityMetrics.getMetricRegistry()); // reporters.addRegistry("workloads", ActivityMetrics.getMetricRegistry());

2
engine-core/src/main/java/io/nosqlbench/engine/core/lifecycle/activity/ActivityExecutor.java
View File

@@ -422,7 +422,7 @@ public class ActivityExecutor implements NBLabeledElement, ActivityController, P
this.exception = e; this.exception = e;
} finally { } finally {
stoppedAt = System.currentTimeMillis(); stoppedAt = System.currentTimeMillis();
unregisterMetrics(); // TODO: close out metrics outputs on component tree if needed
activity.shutdownActivity(); activity.shutdownActivity();
activity.closeAutoCloseables(); activity.closeAutoCloseables();
ExecutionResult result = new ExecutionResult(startedAt, stoppedAt, "", exception); ExecutionResult result = new ExecutionResult(startedAt, stoppedAt, "", exception);

1
engine-core/src/main/java/io/nosqlbench/engine/core/lifecycle/scenario/context/ActivitiesController.java
View File

@@ -424,7 +424,6 @@ public class ActivitiesController extends NBBaseComponent {
} }
public void reportMetrics() { public void reportMetrics() {
// TODO: metrics
// ActivityMetrics.reportTo(System.out); // ActivityMetrics.reportTo(System.out);
} }

1
nb-api/src/main/java/io/nosqlbench/api/engine/metrics/wrappers/RelevancyMeasures.java
View File

@@ -57,7 +57,6 @@ public class RelevancyMeasures implements NBLabeledElement {
for (RelevancyFunction function : f) { for (RelevancyFunction function : f) {
this.functions.add(function); this.functions.add(function);
function.prependLabels(this); function.prependLabels(this);
// TODO: metrics
// DoubleSummaryGauge gauge = ActivityMetrics.summaryGauge(function, function.getUniqueName()); // DoubleSummaryGauge gauge = ActivityMetrics.summaryGauge(function, function.getUniqueName());
// this.gauges.add(gauge); // this.gauges.add(gauge);
} }

1
nbr-examples/src/test/java/io/nosqlbench/nbr/examples/ScriptExampleTests.java
View File

@@ -85,6 +85,7 @@ public class ScriptExampleTests {
return scenarioResult; return scenarioResult;
} }
@Disabled
@BeforeAll @BeforeAll
public static void logit() { public static void logit() {
System.out.println("Running ASYNC version of Script Integration Tests."); System.out.println("Running ASYNC version of Script Integration Tests.");