minor updates, notes collected into gh issues

engine-cli/src/main/java/io/nosqlbench/engine/cli/NBCLI.java

@@ -242,10 +242,6 @@ public class NBCLI implements Function<String[], Integer>, NBLabeledElement {
 
         NBIO.addGlobalIncludes(options.wantsIncludes());
 
-        // TODO: metrics
-//        ActivityMetrics.setHdrDigits(options.getHdrDigits());
-//        ActivityMetrics.setLabelValidator(options.getAnnotateLabelSpec());
-
         if (options.wantsBasicHelp()) {
             System.out.println(this.loadHelpFile("basic.md"));
             return NBCLI.EXIT_OK;
@@ -366,7 +362,6 @@ public class NBCLI implements Function<String[], Integer>, NBLabeledElement {
                 .build()
         );
 
-        // TODO: metrics
 //        if ((null != reportPromPushTo) || (null != reportGraphiteTo) || (null != options.wantsReportCsvTo())) {
 //            final MetricReporters reporters = MetricReporters.getInstance();
 //            reporters.addRegistry("workloads", ActivityMetrics.getMetricRegistry());

engine-core/src/main/java/io/nosqlbench/engine/core/lifecycle/activity/ActivityExecutor.java

@@ -422,7 +422,7 @@ public class ActivityExecutor implements NBLabeledElement, ActivityController, P
                 this.exception = e;
             } finally {
                 stoppedAt = System.currentTimeMillis();
-                unregisterMetrics();
+                // TODO: close out metrics outputs on component tree if needed
                 activity.shutdownActivity();
                 activity.closeAutoCloseables();
                 ExecutionResult result = new ExecutionResult(startedAt, stoppedAt, "", exception);

engine-core/src/main/java/io/nosqlbench/engine/core/lifecycle/scenario/context/ActivitiesController.java

@@ -424,7 +424,6 @@ public class ActivitiesController extends NBBaseComponent {
     }
 
     public void reportMetrics() {
-        // TODO: metrics
 //        ActivityMetrics.reportTo(System.out);
     }
 

nb-api/src/main/java/io/nosqlbench/api/engine/metrics/wrappers/RelevancyMeasures.java

@@ -57,7 +57,6 @@ public class RelevancyMeasures implements NBLabeledElement {
         for (RelevancyFunction function : f) {
             this.functions.add(function);
             function.prependLabels(this);
-            // TODO: metrics
             // DoubleSummaryGauge gauge = ActivityMetrics.summaryGauge(function, function.getUniqueName());
             // this.gauges.add(gauge);
         }

nbr-examples/src/test/java/io/nosqlbench/nbr/examples/ScriptExampleTests.java

@@ -85,6 +85,7 @@ public class ScriptExampleTests {
         return scenarioResult;
     }
 
+    @Disabled
     @BeforeAll
     public static void logit() {
         System.out.println("Running ASYNC version of Script Integration Tests.");