mirror of
https://github.com/nosqlbench/nosqlbench.git
synced 2025-02-25 18:55:28 -06:00
rehome all metrics construction patterns, remove ActivityMetrics
This commit is contained in:
@@ -18,7 +18,6 @@ package io.nosqlbench.engine.api.activityapi.ratelimits;
|
||||
|
||||
import com.codahale.metrics.Gauge;
|
||||
import io.nosqlbench.api.labels.NBLabeledElement;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.components.NBBaseComponent;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
import io.nosqlbench.nb.annotations.Service;
|
||||
|
||||
@@ -20,7 +20,6 @@ import com.codahale.metrics.Timer;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
import io.nosqlbench.engine.api.util.Colors;
|
||||
import io.nosqlbench.api.engine.activityimpl.ActivityDef;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
|
||||
|
||||
@@ -18,7 +18,6 @@ package io.nosqlbench.engine.api.activityapi.ratelimits;
|
||||
|
||||
import com.codahale.metrics.Timer;
|
||||
import io.nosqlbench.api.labels.NBLabeledElement;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
import org.apache.logging.log4j.LogManager;
|
||||
import org.apache.logging.log4j.Logger;
|
||||
|
||||
@@ -33,7 +33,6 @@ import io.nosqlbench.adapters.api.activityimpl.OpMapper;
|
||||
import io.nosqlbench.api.labels.NBLabels;
|
||||
import io.nosqlbench.api.config.standard.NBConfiguration;
|
||||
import io.nosqlbench.api.engine.activityimpl.ActivityDef;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.api.errors.BasicError;
|
||||
import io.nosqlbench.api.errors.OpConfigError;
|
||||
import io.nosqlbench.engine.api.activityapi.cyclelog.filters.IntPredicateDispenser;
|
||||
|
||||
@@ -18,8 +18,6 @@ package io.nosqlbench.engine.api.activityimpl.input;
|
||||
import com.codahale.metrics.Gauge;
|
||||
import io.nosqlbench.api.engine.activityimpl.ActivityDef;
|
||||
import io.nosqlbench.api.engine.activityimpl.CyclesSpec;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.api.engine.metrics.instruments.NBFunctionGauge;
|
||||
import io.nosqlbench.components.NBBaseComponent;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
import io.nosqlbench.engine.api.activityapi.core.ActivityDefObserver;
|
||||
|
||||
@@ -30,8 +30,6 @@ import io.nosqlbench.api.Shutdownable;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
import io.nosqlbench.api.config.standard.*;
|
||||
import io.nosqlbench.api.engine.activityimpl.ActivityDef;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.api.engine.metrics.instruments.NBFunctionGauge;
|
||||
import io.nosqlbench.api.errors.BasicError;
|
||||
import io.nosqlbench.api.errors.OpConfigError;
|
||||
import io.nosqlbench.api.labels.NBLabels;
|
||||
|
||||
@@ -17,7 +17,6 @@
|
||||
package io.nosqlbench.engine.api.metrics;
|
||||
|
||||
import com.codahale.metrics.Counter;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
|
||||
import java.util.ArrayList;
|
||||
|
||||
@@ -19,7 +19,6 @@ package io.nosqlbench.engine.api.metrics;
|
||||
import com.codahale.metrics.Histogram;
|
||||
import io.nosqlbench.api.labels.NBLabeledElement;
|
||||
import io.nosqlbench.api.engine.activityimpl.ActivityDef;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
|
||||
import java.util.ArrayList;
|
||||
|
||||
@@ -17,8 +17,6 @@
|
||||
package io.nosqlbench.engine.api.metrics;
|
||||
|
||||
import com.codahale.metrics.Meter;
|
||||
import io.nosqlbench.api.labels.NBLabeledElement;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
|
||||
import java.util.ArrayList;
|
||||
|
||||
@@ -17,9 +17,7 @@
|
||||
package io.nosqlbench.engine.api.metrics;
|
||||
|
||||
import com.codahale.metrics.Timer;
|
||||
import io.nosqlbench.api.labels.NBLabeledElement;
|
||||
import io.nosqlbench.api.engine.activityimpl.ActivityDef;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import io.nosqlbench.components.NBComponent;
|
||||
|
||||
import java.util.ArrayList;
|
||||
|
||||
@@ -1,63 +0,0 @@
|
||||
/*
|
||||
* Copyright (c) 2022-2023 nosqlbench
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package io.nosqlbench.engine.api.metrics;
|
||||
|
||||
import com.codahale.metrics.Metric;
|
||||
import com.codahale.metrics.MetricRegistry;
|
||||
import io.nosqlbench.api.engine.metrics.ActivityMetrics;
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import java.util.Map;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
public class ActivityMetricsTest {
|
||||
|
||||
@Test
|
||||
public void testMountSubRegistry() throws Exception {
|
||||
MetricRegistry r1 = new MetricRegistry();
|
||||
r1.counter("counter1");
|
||||
|
||||
int extant = ActivityMetrics.getMetricRegistry().getMetrics().size();
|
||||
|
||||
ActivityMetrics.mountSubRegistry("aprefixhere_",r1);
|
||||
Map<String, Metric> metrics = ActivityMetrics.getMetricRegistry().getMetrics();
|
||||
assertThat(metrics).containsKey("aprefixhere_counter1");
|
||||
assertThat(metrics).hasSize(extant+1);
|
||||
|
||||
r1.counter("counter2");
|
||||
metrics = ActivityMetrics.getMetricRegistry().getMetrics();
|
||||
assertThat(metrics).hasSize(extant+2);
|
||||
assertThat(metrics).containsKey("aprefixhere_counter2");
|
||||
|
||||
r1.remove("counter1");
|
||||
metrics = ActivityMetrics.getMetricRegistry().getMetrics();
|
||||
assertThat(metrics).hasSize(extant+1);
|
||||
assertThat(metrics).containsKey("aprefixhere_counter2");
|
||||
|
||||
r1.remove("counter2");
|
||||
metrics = ActivityMetrics.getMetricRegistry().getMetrics();
|
||||
assertThat(metrics).hasSize(extant);
|
||||
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testSanityCheckSanitize() {
|
||||
String result = ActivityMetrics.sanitize("test-dynamic-params.input_cycles_first");
|
||||
assertThat(result).isEqualTo("test_dynamic_params__input_cycles_first");
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user