Merge pull request #333 from XN137/jdk-string-join

prefer jdk over lib internals for String join
This commit is contained in:
Jonathan Shook 2021-06-17 09:52:50 -05:00 committed by GitHub
commit a02df22d41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions

View File

@ -30,7 +30,6 @@ import io.nosqlbench.nb.api.errors.BasicError;
import io.nosqlbench.nb.api.logging.NBLogLevel;
import io.nosqlbench.nb.api.markdown.exporter.MarkdownExporter;
import io.nosqlbench.virtdata.userlibs.apps.VirtDataMainApp;
import joptsimple.internal.Strings;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.core.config.ConfigurationFactory;
@ -299,7 +298,7 @@ public class NBCLI {
.session(sessionName)
.now()
.layer(Layer.CLI)
.detail("cli", Strings.join(args, "\n"))
.detail("cli", String.join("\n", args))
.build()
);

View File

@ -2,7 +2,6 @@ package io.nosqlbench.engine.cli;
import io.nosqlbench.nb.api.NBEnvironment;
import io.nosqlbench.nb.api.errors.BasicError;
import joptsimple.internal.Strings;
import org.apache.logging.log4j.Logger;
import java.io.IOException;
@ -426,13 +425,13 @@ public class NBCLIArgsFile {
String word = iter.next();
if (word.startsWith("-")) {
if (element.size() > 0) {
lines.add(Strings.join(element, " "));
lines.add(String.join(" ", element));
element.clear();
}
}
element.add(word);
}
lines.add(Strings.join(element, " "));
lines.add(String.join(" ", element));
return lines;
}