Comments on branch. You can truncate this commit after reading.

This commit is contained in:
Jonathan Shook
2023-05-08 12:31:01 -05:00
parent be9b97e2cd
commit a8ce71f9e7
5 changed files with 25 additions and 6 deletions

View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022 nosqlbench
* Copyright (c) 2022-2023 nosqlbench
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -69,6 +69,8 @@ public abstract class BaseOpDispenser<T extends Op, S> implements OpDispenser<T>
configureExpectations(op);
}
// TODO/MVEL: Please add some error handling around that explains to the user
// what happened in the event of a compilation failure.
private void configureExpectations(ParsedOp op) {
op.getOptionalStaticValue("expected-result", String.class)
.map(MVEL::compileExpression)

View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022 nosqlbench
* Copyright (c) 2022-2023 nosqlbench
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -33,6 +33,8 @@ package io.nosqlbench.engine.api.activityimpl.uniform.flowtypes;
*/
// TODO: optimize the runtime around the specific op type
public interface Op extends OpResultSize {
// TODO/MVEL: Let's take this out of here to keep Op as a tagging interface
// I think it will sit fine on the BaseOpDispenser, and lifecycles align for this nicely
default boolean verified() {
return false;
}