IntenseFinance/nosqlbench
3
0
Fork 0
mirror of https://github.com/nosqlbench/nosqlbench.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

avoid repeating initial error message

Browse Source
This commit is contained in:
Jonathan Shook 2020-07-16 09:20:42 -05:00
parent 1db36d849b
commit c81c5187c2
7 changed files with 43 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docsys/src/main/java/io/nosqlbench/docsys/core/DocServer.java
View File

@ -305,7 +305,7 @@ public class DocServer implements Runnable {
server.join();
} catch (Exception e) {
logger.error(e.getMessage(), e);
logger.error("error while starting doc server", e);
e.printStackTrace(System.out);
System.exit(2);
}

2
driver-cqld4/src/main/java/io/nosqlbench/activitytype/cqld4/errorhandling/NBCycleErrorHandler.java
View File

@ -67,7 +67,7 @@ public class NBCycleErrorHandler implements CycleErrorHandler<Throwable, ErrorSt
boolean retry = false;
switch (errorResponse) {
case stop:
logger.error("error with cycle " + cycle + ": statement: " + cce.getStatement() + " errmsg: " + error.getMessage());
logger.error("error with cycle " + cycle + ": statement: " + cce.getStatement() + " errmsg: ",error);
if (throwExceptionOnStop) {
throw new RuntimeException(error);
}

4
driver-http/src/main/java/io/nosqlbench/activitytype/http/HttpAction.java
View File

@ -74,7 +74,7 @@ public class HttpAction implements SyncAction {
ReadyHttpRequest readyHttpRequest = httpActivity.getOpSequence().get(cycleValue);
request =readyHttpRequest.apply(cycleValue);
} catch (Exception e) {
throw new RuntimeException("while binding request in cycle " + cycleValue + ": " + e.getMessage(),e);
throw new RuntimeException("while binding request in cycle " + cycleValue + ": ",e);
}
int tries = 0;
@ -92,7 +92,7 @@ public class HttpAction implements SyncAction {
try (Timer.Context resultTime = httpActivity.resultTimer.time()) {
response = responseFuture.get(httpActivity.getTimeoutMs(), TimeUnit.MILLISECONDS);
} catch (Exception e) {
throw new RuntimeException("while waiting for response in cycle " + cycleValue + ":" + e.getMessage(), e);
throw new RuntimeException("while waiting for response in cycle " + cycleValue + ":", e);
}
// if (ok == null) {

2
engine-api/src/main/java/io/nosqlbench/engine/api/activityapi/sysperf/SysPerf.java
View File

@ -117,7 +117,7 @@ public class SysPerf {
logger.info("Loaded previously cached system timing data from " + cache.getCanonicalPath());
return cachedData;
} catch (IOException e) {
logger.error(e.getMessage(),e);
logger.error("error while loading sysperf data",e);
if (cache.exists()) {
boolean deleted = cache.delete();
if (deleted) {

11
engine-api/src/main/java/io/nosqlbench/engine/api/scripting/NashornEvaluator.java
View File

@ -71,8 +71,7 @@ public class NashornEvaluator<T> implements Evaluator<T> {
logger.trace("Did not compile script: " + script);
}
} catch (ScriptException e) {
String errorDesc = "Script compilation error for " + scriptText + ": " + e.getMessage();
throw new RuntimeException(errorDesc, e);
throw new RuntimeException("Script compilation error for " + scriptText + ": ", e);
}
return this;
}
@ -96,13 +95,9 @@ public class NashornEvaluator<T> implements Evaluator<T> {
}
result = convert(resultType, evaled);
} catch (ScriptException e) {
String errorDesc = "Script error while evaluating result for '" + script + "':" + e.getMessage();
logger.error(errorDesc, e);
throw new RuntimeException(errorDesc, e);
throw new RuntimeException("Script error while evaluating result for '" + script + "':", e);
} catch (Exception o) {
String errorDesc = "Non-Script error while evaluating result for '" + script + "':" + o.getMessage();
logger.error(errorDesc, o);
throw new RuntimeException(errorDesc, o);
throw new RuntimeException("Non-Script error while evaluating result for '" + script + "':", o);
}
return result;
}

67
engine-cli/src/main/java/io/nosqlbench/engine/cli/NBCLI.java
View File

@ -52,8 +52,8 @@ public class NBCLI {
cli.run(args);
} catch (Exception e) {
if (e instanceof BasicError) {
System.out.println("ERROR: " + e.getMessage());
System.out.flush();
// System.out.println("ERROR: " + e.getMessage());
// System.out.flush();
logger.error("ERROR: " + e.getMessage());
System.exit(2);
} else {
@ -71,8 +71,8 @@ public class NBCLI {
DocServerApp.main(Arrays.copyOfRange(args, 1, args.length));
System.exit(0);
}
if (args.length>0 && args[0].toLowerCase().equals(MarkdownExporter.APP_NAME)) {
MarkdownExporter.main(Arrays.copyOfRange(args,1,args.length));
if (args.length > 0 && args[0].toLowerCase().equals(MarkdownExporter.APP_NAME)) {
MarkdownExporter.main(Arrays.copyOfRange(args, 1, args.length));
System.exit(0);
}
@ -118,22 +118,22 @@ public class NBCLI {
logger.debug("user requests to copy out " + resourceToCopy);
Optional<Content<?>> tocopy = NBIO.classpath()
.prefix("activities")
.prefix(options.wantsIncludes())
.name(resourceToCopy).extension("yaml").first();
.prefix("activities")
.prefix(options.wantsIncludes())
.name(resourceToCopy).extension("yaml").first();
if (tocopy.isEmpty()) {
tocopy = NBIO.classpath()
.prefix().prefix(options.wantsIncludes())
.prefix(options.wantsIncludes())
.name(resourceToCopy).first();
.prefix().prefix(options.wantsIncludes())
.prefix(options.wantsIncludes())
.name(resourceToCopy).first();
}
Content<?> data = tocopy.orElseThrow(
() -> new BasicError(
"Unable to find " + resourceToCopy +
" in classpath to copy out")
() -> new BasicError(
"Unable to find " + resourceToCopy +
" in classpath to copy out")
);
Path writeTo = Path.of(data.asPath().getFileName().toString());
@ -173,7 +173,7 @@ public class NBCLI {
if (options.wantsTopicalHelp()) {
Optional<String> helpDoc = MarkdownDocInfo.forHelpTopic(options.wantsTopicalHelpFor());
System.out.println(helpDoc.orElseThrow(
() -> new RuntimeException("No help could be found for " + options.wantsTopicalHelpFor())
() -> new RuntimeException("No help could be found for " + options.wantsTopicalHelpFor())
));
System.exit(0);
}
@ -190,19 +190,19 @@ public class NBCLI {
if (options.wantsDockerMetrics()) {
logger.info("Docker metrics is enabled. Docker must be installed for this to work");
DockerMetricsManager dmh = new DockerMetricsManager();
Map<String,String> dashboardOptions = Map.of(
Map<String, String> dashboardOptions = Map.of(
DockerMetricsManager.GRAFANA_TAG, options.getDockerGrafanaTag()
);
dmh.startMetrics(dashboardOptions);
String warn = "Docker Containers are started, for grafana and prometheus, hit" +
" these urls in your browser: http://<host>:3000 and http://<host>:9090";
" these urls in your browser: http://<host>:3000 and http://<host>:9090";
logger.warn(warn);
if (reportGraphiteTo != null) {
logger.warn(String.format("Docker metrics are enabled (--docker-metrics)" +
" but graphite reporting (--report-graphite-to) is set to %s \n" +
"usually only one of the two is configured.",
reportGraphiteTo));
" but graphite reporting (--report-graphite-to) is set to %s \n" +
"usually only one of the two is configured.",
reportGraphiteTo));
} else {
//TODO: is this right?
logger.info("Setting graphite reporting to localhost");
@ -257,16 +257,17 @@ public class NBCLI {
ScenariosExecutor executor = new ScenariosExecutor("executor-" + sessionName, 1);
Scenario scenario = new Scenario(
sessionName,
options.getScriptingEngine(),
options.getProgressSpec(),
options.wantsGraaljsCompatMode()
sessionName,
options.getScriptingEngine(),
options.getProgressSpec(),
options.wantsGraaljsCompatMode(),
options.wantsStackTraces()
);
ScriptBuffer buffer = new BasicScriptBuffer(
options.getLogsDirectory()+ FileSystems.getDefault().getSeparator()+ "_scenario."+ scenario.getName() +".js"
options.getLogsDirectory() + FileSystems.getDefault().getSeparator() + "_scenario." + scenario.getName() + ".js"
).add(options.getCommands().toArray(new Cmd[0]));
String scriptData = buffer.getParsedScript();
Map<String,String> globalParams=buffer.getCombinedParams();
Map<String, String> globalParams = buffer.getCombinedParams();
if (options.wantsShowScript()) {
System.out.println("// Rendered Script");
@ -286,7 +287,7 @@ public class NBCLI {
Level clevel = options.wantsConsoleLogLevel();
Level llevel = Level.toLevel(options.getLogsLevel());
if (llevel.toInt()>clevel.toInt()) {
if (llevel.toInt() > clevel.toInt()) {
logger.info("raising scenario logging level to accommodate console logging level");
}
Level maxLevel = Level.toLevel(Math.min(clevel.toInt(), llevel.toInt()));
@ -296,11 +297,11 @@ public class NBCLI {
scriptParams.putAll(buffer.getCombinedParams());
scenario.addScenarioScriptParams(scriptParams);
ScenarioLogger sl = new ScenarioLogger(scenario)
.setLogDir(options.getLogsDirectory())
.setMaxLogs(options.getLogsMax())
.setLevel(maxLevel)
.setLogLevelOverrides(options.getLogLevelOverrides())
.start();
.setLogDir(options.getLogsDirectory())
.setMaxLogs(options.getLogsMax())
.setLevel(maxLevel)
.setLogLevelOverrides(options.getLogLevelOverrides())
.start();
executor.execute(scenario, sl);
@ -320,9 +321,7 @@ public class NBCLI {
ShutdownManager.shutdown();
if (scenariosResults.hasError()) {
Exception exception = scenariosResults.getOne().getException().get();
System.err.println("ERROR while running scenario: " + exception.getMessage());
exception.printStackTrace(System.err);
logger.info(scenariosResults.getExecutionSummary());
System.exit(2);
} else {
System.exit(0);

5
engine-core/src/main/java/io/nosqlbench/engine/core/ActivityExecutor.java
View File

@ -98,9 +98,8 @@ public class ActivityExecutor implements ActivityController, ParameterMap.Listen
activity.initActivity();
//activity.onActivityDefUpdate(activityDef);
} catch (Exception e) {
this.stoppingException = new RuntimeException("Error initializing activity '" +
activity.getAlias() +"': " + e.getMessage(),e);
activitylogger.error("error initializing activity '" + activity.getAlias() + "': " + stoppingException);
this.stoppingException = new RuntimeException("Error initializing activity '" + activity.getAlias() +"':\n" + e.getMessage(),e);
// activitylogger.error("error initializing activity '" + activity.getAlias() + "': " + stoppingException);
throw stoppingException;
}
adjustToActivityDef(activity.getActivityDef());