IntenseFinance/nosqlbench
3
0
Fork 0
mirror of https://github.com/nosqlbench/nosqlbench.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

make op synthesis even more defensive

Browse Source
This commit is contained in:
Jonathan Shook 2023-01-19 23:54:58 -06:00
parent afaa6f5b93
commit dbf3df1e33
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
engine-api/src/main/java/io/nosqlbench/engine/api/activityimpl/SimpleActivity.java
View File

@ -193,7 +193,7 @@ public class SimpleActivity implements Activity, ProgressCapable, ActivityDefObs
} }
public String toString() { public String toString() {
return getAlias()+":"+getRunState()+":"+getRunStateTally().toString(); return getAlias() + ":" + getRunState() + ":" + getRunStateTally().toString();
} }
@Override @Override
@ -486,7 +486,7 @@ public class SimpleActivity implements Activity, ProgressCapable, ActivityDefObs
.orElse(SequencerType.bucket); .orElse(SequencerType.bucket);
SequencePlanner<OpDispenser<? extends O>> planner = new SequencePlanner<>(sequencerType); SequencePlanner<OpDispenser<? extends O>> planner = new SequencePlanner<>(sequencerType);
int dryrunCount=0; int dryrunCount = 0;
for (int i = 0; i < pops.size(); i++) { for (int i = 0; i < pops.size(); i++) {
long ratio = ratios.get(i); long ratio = ratios.get(i);
ParsedOp pop = pops.get(i); ParsedOp pop = pops.get(i);
@ -510,7 +510,7 @@ public class SimpleActivity implements Activity, ProgressCapable, ActivityDefObs
// } // }
planner.addOp((OpDispenser<? extends O>) dispenser, ratio); planner.addOp((OpDispenser<? extends O>) dispenser, ratio);
} }
if (dryrunCount>0) { if (dryrunCount > 0) {
logger.warn("initialized " + dryrunCount + " op templates for dry run only. These ops will be synthesized for each cycle, but will not be executed."); logger.warn("initialized " + dryrunCount + " op templates for dry run only. These ops will be synthesized for each cycle, but will not be executed.");
} }
@ -547,22 +547,33 @@ public class SimpleActivity implements Activity, ProgressCapable, ActivityDefObs
protected List<OpTemplate> loadOpTemplates(Optional<DriverAdapter> defaultDriverAdapter) { protected List<OpTemplate> loadOpTemplates(Optional<DriverAdapter> defaultDriverAdapter) {
String tagfilter = activityDef.getParams().getOptionalString("tags").orElse(""); String tagfilter = activityDef.getParams().getOptionalString("tags").orElse("");
// StrInterpolator interp = new StrInterpolator(activityDef);
StmtsDocList stmtsDocList = loadStmtsDocList(); StmtsDocList stmtsDocList = loadStmtsDocList();
List<OpTemplate> unfilteredOps = stmtsDocList.getStmts(); List<OpTemplate> unfilteredOps = stmtsDocList.getStmts();
List<OpTemplate> filteredOps = stmtsDocList.getStmts(tagfilter); List<OpTemplate> filteredOps = stmtsDocList.getStmts(tagfilter);
if (filteredOps.size() == 0) { if (filteredOps.size() == 0) {
if (unfilteredOps.size() > 0) { if (unfilteredOps.size() > 0) { // There were no ops, and it was because they were all filtered out
throw new BasicError("There were no active statements with tag filter '" throw new BasicError("There were no active statements with tag filter '"
+ tagfilter + "', since all " + unfilteredOps.size() + " were filtered out."); + tagfilter + "', since all " + unfilteredOps.size() + " were filtered out.");
} else { } else {
// There were no ops, and it *wasn't* because they were all filtered out.
// In this case, let's try to synthesize the ops as long as at least a default driver was provided
if (defaultDriverAdapter.isPresent() && defaultDriverAdapter.get() instanceof SyntheticOpTemplateProvider sotp) { if (defaultDriverAdapter.isPresent() && defaultDriverAdapter.get() instanceof SyntheticOpTemplateProvider sotp) {
filteredOps = sotp.getSyntheticOpTemplates(stmtsDocList, getActivityDef().getParams()); filteredOps = sotp.getSyntheticOpTemplates(stmtsDocList, getActivityDef().getParams());
Objects.requireNonNull(filteredOps); Objects.requireNonNull(filteredOps);
if (filteredOps.size() == 0) {
throw new BasicError("Attempted to create synthetic ops from driver '" + defaultDriverAdapter.get().getAdapterName() + "'" +
" but no ops were created. You must provide either a workload or an op parameter. Activities require op templates.");
}
} else { // But if there were no ops, and there was no default driver provided, we can't continue
throw new BasicError("""
No op templates were provided. You must provide one of these activity parameters:
1) workload=some.yaml
2) op='inline template
3) driver=stdout (or any other drive that can synthesize ops)""");
} }
} }
if (filteredOps.size() == 0) { if (filteredOps.size() == 0) {