IntenseFinance/nosqlbench
3
0
Fork 0
mirror of https://github.com/nosqlbench/nosqlbench.git synced 2025-01-15 18:32:04 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add safety warnings for improper use of config getters

Browse Source
This commit is contained in:
Jonathan Shook 2020-06-18 11:03:37 -05:00
parent 2d0b37443e
commit efd7e77e8a
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
engine-api/src/main/java/io/nosqlbench/engine/api/activityconfig/yaml/StmtDef.java
View File

@ -68,7 +68,11 @@ public class StmtDef implements Tagged {
return defaultValue;
}
Object value = lookup.get(name);
return (V) defaultValue.getClass().cast(value);
try {
return (V) defaultValue.getClass().cast(value);
} catch (Exception e) {
throw new RuntimeException("Unable to cast type " + value.getClass().getCanonicalName() + " to " + defaultValue.getClass().getCanonicalName(), e);
}
}
public <V> V getParam(String name, Class<? extends V> type) {
@ -80,13 +84,22 @@ public class StmtDef implements Tagged {
@SuppressWarnings("unchecked")
public <V> Optional<V> getOptionalParam(String name, Class<? extends V> type) {
if (type.isPrimitive()) {
throw new RuntimeException("Do not use primitive types for the target class here. For example, Boolean.class is accepted, but boolean.class is not.");
}
// TODO: add warning here if primitive types are not allowed
MultiMapLookup<Object> lookup = new MultiMapLookup<>(rawStmtDef.getParams(), block.getParams());
if (lookup.containsKey(name)) {
Object object = lookup.get(name);
if (object==null) {
return Optional.empty();
}
return Optional.of((V) type.cast(object));
try {
V reified = type.cast(object);
return Optional.of(reified);
} catch (Exception e) {
throw new RuntimeException("Unable to cast type " + object.getClass().getCanonicalName() + " to " + type.getCanonicalName());
}
}
return Optional.empty();
}