Revert "mobile: hide observer role from UI (to be reverted after v4.5.4 is released)"

This reverts commit 37d0bc2f14.

apps/android/app/src/main/java/chat/simplex/app/model/ChatModel.kt

@@ -950,7 +950,7 @@ data class GroupMember (
   fun canChangeRoleTo(groupInfo: GroupInfo): List<GroupMemberRole>? =
     if (!canBeRemoved(groupInfo)) null
     else groupInfo.membership.memberRole.let { userRole ->
-      GroupMemberRole.values().filter { it <= userRole && it != GroupMemberRole.Observer }
+      GroupMemberRole.values().filter { it <= userRole }
     }
 
   val memberIncognito = memberProfile.profileId != memberContactProfileId

apps/android/app/src/main/java/chat/simplex/app/views/chat/group/AddGroupMembersView.kt

@@ -166,7 +166,7 @@ private fun RoleSelectionRow(groupInfo: GroupInfo, selectedRole: MutableState<Gr
     verticalAlignment = Alignment.CenterVertically,
     horizontalArrangement = Arrangement.SpaceBetween
   ) {
-    val values = GroupMemberRole.values().filter { it <= groupInfo.membership.memberRole && it != GroupMemberRole.Observer }.map { it to it.text }
+    val values = GroupMemberRole.values().filter { it <= groupInfo.membership.memberRole }.map { it to it.text }
     ExposedDropDownSettingRow(
       generalGetString(R.string.new_member_role),
       values,

apps/android/app/src/main/java/chat/simplex/app/views/chat/group/GroupLinkView.kt

@@ -120,9 +120,9 @@ fun GroupLinkLayout(
       if (groupLink == null) {
         SimpleButton(stringResource(R.string.button_create_group_link), icon = Icons.Outlined.AddLink, disabled = creatingLink, click = createLink)
       } else {
-//        SectionItemView(padding = PaddingValues(bottom = DEFAULT_PADDING)) {
-//          RoleSelectionRow(groupInfo, groupLinkMemberRole)
-//        }
+        SectionItemView(padding = PaddingValues(bottom = DEFAULT_PADDING)) {
+          RoleSelectionRow(groupInfo, groupLinkMemberRole)
+        }
         var initialLaunch by remember { mutableStateOf(true) }
         LaunchedEffect(groupLinkMemberRole.value) {
           if (!initialLaunch) {

apps/ios/Shared/Views/Chat/Group/AddGroupMembersView.swift

@@ -140,7 +140,7 @@ struct AddGroupMembersView: View {
     private func rolePicker() -> some View {
         Picker("New member role", selection: $selectedRole) {
             ForEach(GroupMemberRole.allCases) { role in
-                if role <= groupInfo.membership.memberRole && role != .observer {
+                if role <= groupInfo.membership.memberRole {
                     Text(role.text)
                 }
             }

apps/ios/Shared/Views/Chat/Group/GroupLinkView.swift

@@ -34,15 +34,15 @@ struct GroupLinkView: View {
                 Text("You can share a link or a QR code - anybody will be able to join the group. You won't lose members of the group if you later delete it.")
                     .padding(.bottom)
                 if let groupLink = groupLink {
-//                    HStack {
-//                        Text("Initial role")
-//                        Picker("Initial role", selection: $groupLinkMemberRole) {
-//                            ForEach([GroupMemberRole.member, GroupMemberRole.observer]) { role in
-//                                Text(role.text)
-//                            }
-//                        }
-//                    }
-//                    .frame(maxWidth: .infinity, alignment: .leading)
+                    HStack {
+                        Text("Initial role")
+                        Picker("Initial role", selection: $groupLinkMemberRole) {
+                            ForEach([GroupMemberRole.member, GroupMemberRole.observer]) { role in
+                                Text(role.text)
+                            }
+                        }
+                    }
+                    .frame(maxWidth: .infinity, alignment: .leading)
                     QRCode(uri: groupLink)
                     HStack {
                         Button {

apps/ios/SimpleXChat/ChatTypes.swift

@@ -1532,7 +1532,7 @@ public struct GroupMember: Identifiable, Decodable {
     public func canChangeRoleTo(groupInfo: GroupInfo) -> [GroupMemberRole]? {
         if !canBeRemoved(groupInfo: groupInfo) { return nil }
         let userRole = groupInfo.membership.memberRole
-        return GroupMemberRole.allCases.filter { $0 <= userRole && $0 != .observer }
+        return GroupMemberRole.allCases.filter { $0 <= userRole }
     }
 
     public var memberIncognito: Bool {