From e91bc46a0f5c786624ed80c3c331c18b745128fe Mon Sep 17 00:00:00 2001
From: Mershl <mweires@googlemail.com>
Date: Thu, 22 Feb 2024 21:18:02 +0100
Subject: [PATCH] fix: avoid selectable labels for dynamic info (#270)

Make InfoRow labels not selectable by default. Allow an override of the attribute in the template (for Software tab for example).

Motivation:
GTK will place the blinking cursor on the first selectable label of a view/tab. Placing the cursor on dynamic info like the current GPU Core Clock will show the cursor jumping around as the number of digits change a lot (best seen in the OC tab).

As the selection of a label is discarded on update of a label (which happens multiple times a second for a lot of the OC and Thermals values) the cursor is just a visual distraction rather than a feature.
---
 lact-gui/src/app/info_row.rs  | 2 ++
 lact-gui/ui/info_row.blp      | 2 +-
 lact-gui/ui/software_page.blp | 3 +++
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/lact-gui/src/app/info_row.rs b/lact-gui/src/app/info_row.rs
index 426c525..748c6ba 100644
--- a/lact-gui/src/app/info_row.rs
+++ b/lact-gui/src/app/info_row.rs
@@ -37,6 +37,8 @@ mod imp {
         name: RefCell<String>,
         #[property(get, set)]
         value: RefCell<String>,
+        #[property(get, set)]
+        selectable: RefCell<bool>,
 
         #[template_child]
         value_label: TemplateChild<Label>,
diff --git a/lact-gui/ui/info_row.blp b/lact-gui/ui/info_row.blp
index 045fdef..fd4fee3 100644
--- a/lact-gui/ui/info_row.blp
+++ b/lact-gui/ui/info_row.blp
@@ -14,7 +14,7 @@ template $InfoRow: Box {
     Label value_label {
         label: bind template.value;
         halign: end;
-        selectable: true;
+        selectable: bind template.selectable;
         use-markup: true;
     }
 }
diff --git a/lact-gui/ui/software_page.blp b/lact-gui/ui/software_page.blp
index dd3df7c..8858fa1 100644
--- a/lact-gui/ui/software_page.blp
+++ b/lact-gui/ui/software_page.blp
@@ -11,15 +11,18 @@ template $SoftwarePage: Box {
     $InfoRow {
         name: "LACT Daemon:";
         value: bind template.daemon_version;
+        selectable: true;
     }
 
     $InfoRow {
         name: "LACT GUI:";
         value: bind template.gui_version;
+        selectable: true;
     }
 
     $InfoRow {
         name: "Kernel Version:";
         value: bind template.kernel_version;
+        selectable: true;
     }
 }