diff --git a/src/rust/lqosd/src/node_manager/js_build/src/dashlets/top10_downloaders.js b/src/rust/lqosd/src/node_manager/js_build/src/dashlets/top10_downloaders.js index 248bc5b2..df1f8b6e 100644 --- a/src/rust/lqosd/src/node_manager/js_build/src/dashlets/top10_downloaders.js +++ b/src/rust/lqosd/src/node_manager/js_build/src/dashlets/top10_downloaders.js @@ -1,6 +1,6 @@ import {BaseDashlet} from "./base_dashlet"; import {RttHistogram} from "../graphs/rtt_histo"; -import {clearDashDiv, theading, topNTableHeader, topNTableRow} from "../helpers/builders"; +import {clearDashDiv, theading, TopNTableFromMsgData, topNTableHeader, topNTableRow} from "../helpers/builders"; import {scaleNumber, rttCircleSpan, formatThroughput, formatRtt, formatRetransmit} from "../helpers/scaling"; import {redactCell} from "../helpers/redact"; @@ -36,16 +36,7 @@ export class Top10Downloaders extends BaseDashlet { if (msg.event === "TopDownloads") { let target = document.getElementById(this.id); - let t = document.createElement("table"); - t.classList.add("table", "table-striped", "table-sm"); - - t.appendChild(topNTableHeader()); - - let tbody = document.createElement("tbody"); - msg.data.forEach((r) => { - t.appendChild(topNTableRow(r)); - }); - t.appendChild(tbody); + let t = TopNTableFromMsgData(msg); // Display it clearDashDiv(this.id, target); diff --git a/src/rust/lqosd/src/node_manager/js_build/src/dashlets/worst10_downloaders.js b/src/rust/lqosd/src/node_manager/js_build/src/dashlets/worst10_downloaders.js index 1ed33972..aaff76fe 100644 --- a/src/rust/lqosd/src/node_manager/js_build/src/dashlets/worst10_downloaders.js +++ b/src/rust/lqosd/src/node_manager/js_build/src/dashlets/worst10_downloaders.js @@ -1,6 +1,6 @@ import {BaseDashlet} from "./base_dashlet"; import {RttHistogram} from "../graphs/rtt_histo"; -import {clearDashDiv, theading, topNTableHeader, topNTableRow} from "../helpers/builders"; +import {clearDashDiv, theading, TopNTableFromMsgData, topNTableHeader, topNTableRow} from "../helpers/builders"; import {scaleNumber, rttCircleSpan, formatThroughput, formatRtt} from "../helpers/scaling"; import {redactCell} from "../helpers/redact"; @@ -36,16 +36,7 @@ export class Worst10Downloaders extends BaseDashlet { if (msg.event === "WorstRTT") { let target = document.getElementById(this.id); - let t = document.createElement("table"); - t.classList.add("table", "table-striped", "small"); - - t.appendChild(topNTableHeader()); - - let tbody = document.createElement("tbody"); - msg.data.forEach((r) => { - t.appendChild(topNTableRow(r)); - }); - t.appendChild(tbody); + let t = TopNTableFromMsgData(msg); // Display it clearDashDiv(this.id, target); diff --git a/src/rust/lqosd/src/node_manager/js_build/src/dashlets/worst10_retransmits.js b/src/rust/lqosd/src/node_manager/js_build/src/dashlets/worst10_retransmits.js index 25cd03b9..7b8299eb 100644 --- a/src/rust/lqosd/src/node_manager/js_build/src/dashlets/worst10_retransmits.js +++ b/src/rust/lqosd/src/node_manager/js_build/src/dashlets/worst10_retransmits.js @@ -1,6 +1,6 @@ import {BaseDashlet} from "./base_dashlet"; import {RttHistogram} from "../graphs/rtt_histo"; -import {clearDashDiv, theading, topNTableHeader, topNTableRow} from "../helpers/builders"; +import {clearDashDiv, theading, TopNTableFromMsgData, topNTableHeader, topNTableRow} from "../helpers/builders"; import {scaleNumber, rttCircleSpan, formatRtt, formatThroughput} from "../helpers/scaling"; import {redactCell} from "../helpers/redact"; @@ -36,16 +36,7 @@ export class Worst10Retransmits extends BaseDashlet { if (msg.event === "WorstRetransmits") { let target = document.getElementById(this.id); - let t = document.createElement("table"); - t.classList.add("table", "table-striped", "tiny"); - - t.appendChild(topNTableHeader()); - - let tbody = document.createElement("tbody"); - msg.data.forEach((r) => { - t.appendChild(topNTableRow(r)); - }); - t.appendChild(tbody); + let t = TopNTableFromMsgData(msg); // Display it clearDashDiv(this.id, target); diff --git a/src/rust/lqosd/src/node_manager/js_build/src/helpers/builders.js b/src/rust/lqosd/src/node_manager/js_build/src/helpers/builders.js index c7de40fc..ef91cc43 100644 --- a/src/rust/lqosd/src/node_manager/js_build/src/helpers/builders.js +++ b/src/rust/lqosd/src/node_manager/js_build/src/helpers/builders.js @@ -157,4 +157,18 @@ export function topNTableRow(r) { row.append(tcp_xmit_up); return row; +} + +export function TopNTableFromMsgData(msg) { + let t = document.createElement("table"); + t.classList.add("table", "table-striped", "table-sm"); + + t.appendChild(topNTableHeader()); + + let tbody = document.createElement("tbody"); + msg.data.forEach((r) => { + t.appendChild(topNTableRow(r)); + }); + t.appendChild(tbody); + return t; } \ No newline at end of file