IntenseWebs/LibreQoS
3
0
Fork 0
mirror of https://github.com/LibreQoE/LibreQoS.git synced 2024-11-22 08:16:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix a missing break - switch fallthrough by mistake - in dissector.h. This fixes a problem with misidentifying traffic as TCP when it is't.

Browse Source
This commit is contained in:
Herbert Wolverson 2023-03-31 17:31:59 +00:00
parent 34e3381af4
commit ebfcde2618
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/rust/lqos_sys/src/bpf/common/dissector.h
View File

@ -345,8 +345,7 @@ static __always_inline void snoop(struct dissector_t *dissector)
parse_tcp_ts(hdr, dissector->end, &dissector->tsval, &dissector->tsecr);
}
}
break;
} break;
case IPPROTO_UDP:
{
struct udphdr *hdr = get_udp_header(dissector);
@ -354,12 +353,13 @@ static __always_inline void snoop(struct dissector_t *dissector)
{
if (hdr + 1 > dissector->end)
{
bpf_debug("UDP header past end");
return;
}
dissector->src_port = hdr->source;
dissector->dst_port = hdr->dest;
}
}
} break;
case IPPROTO_ICMP:
{
struct icmphdr *hdr = get_icmp_header(dissector);
@ -367,14 +367,14 @@ static __always_inline void snoop(struct dissector_t *dissector)
{
if ((char *)hdr + sizeof(struct icmphdr) > dissector->end)
{
bpf_debug("ICMP header past end");
return;
}
dissector->ip_protocol = 1;
dissector->src_port = bpf_ntohs(hdr->type);
dissector->dst_port = bpf_ntohs(hdr->type);
}
}
break;
dissector->dst_port = bpf_ntohs(hdr->code);
}
} break;
}
}