IntenseWebs/PeerTube
3
0
Fork 0
mirror of https://github.com/Chocobozzz/PeerTube.git synced 2026-09-03 20:53:09 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix mentions extractions with punctuations

Browse Source 
Also don't consume spaces in regex, resulting in broken mention
extractions
This commit is contained in:
Chocobozzz
2026-07-13 14:42:23 +02:00
parent 6bc19037a1
commit 09fabc2a3c
3 changed files with 19 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/tests/src/server-helpers/mentions.ts
+8 -3
View File
@@ -1,7 +1,7 @@
/* oxlint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
import { expect } from 'chai'
import { extractMentions } from '@peertube/peertube-server/core/helpers/mentions.js'
import { extractLocalMentions } from '@peertube/peertube-server/core/helpers/mentions.js'
describe('Comment model', function () {
it('Should correctly extract mentions', async function () {
@@ -10,8 +10,13 @@ describe('Comment model', function () {
const isLocal = true
const result = extractMentions(text, isLocal).sort((a, b) => a.localeCompare(b))
const result = extractLocalMentions(text, isLocal)
expect(result).to.deep.equal([ 'another', 'chocobozzz', 'end', 'flo', 'florian', 'jean' ])
expect(result).to.deep.equal([ 'florian', 'jean', 'flo', 'another', 'chocobozzz', 'end' ])
})
it('Should correctly extract mentions with adjacent punctuations and newlines', async function () {
expect(extractLocalMentions('thanks @bob!', true)).to.deep.equal([ 'bob' ])
expect(extractLocalMentions('@bob\n', true)).to.deep.equal([ 'bob' ])
})
})