From 3c9d1ff5e34d4b99e472b4e59fdab3f745b1e281 Mon Sep 17 00:00:00 2001 From: kontrollanten <6680299+kontrollanten@users.noreply.github.com> Date: Tue, 25 Jun 2024 06:11:32 +0200 Subject: [PATCH] client: extend logging In able to make it easier to debug issues. --- client/src/app/core/rest/rest-extractor.service.ts | 3 ++- client/src/assets/player/peertube-player.ts | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/client/src/app/core/rest/rest-extractor.service.ts b/client/src/app/core/rest/rest-extractor.service.ts index f7105e07f..9541306de 100644 --- a/client/src/app/core/rest/rest-extractor.service.ts +++ b/client/src/app/core/rest/rest-extractor.service.ts @@ -90,12 +90,13 @@ export class RestExtractor { } if (err.status !== undefined) { + // A fetch response const errorMessage = this.buildServerErrorMessage(err) const message = `Backend returned code ${err.status}, errorMessage is: ${errorMessage}` if (err.status === HttpStatusCode.NOT_FOUND_404) logger.clientError(message) - else logger.error(message) + else logger.error(message, { type: err.type, url: err.url }) return errorMessage } diff --git a/client/src/assets/player/peertube-player.ts b/client/src/assets/player/peertube-player.ts index aa3709bd7..1805a07c4 100644 --- a/client/src/assets/player/peertube-player.ts +++ b/client/src/assets/player/peertube-player.ts @@ -306,7 +306,12 @@ export class PeerTubePlayer { return } - logger.info('Fast forwarding HLS to recover from an error.') + logger.info('Fast forwarding HLS to recover from an error.', { + err, + videoShortUUID: this.currentLoadOptions.videoShortUUID, + currentTime: this.player.currentTime(), + resolution: this.player.videoHeight() + }) this.videojsDecodeErrors++