From 472f1ec59d30a98201792e8bdd9c1006618c472d Mon Sep 17 00:00:00 2001 From: Adam Silverstein Date: Fri, 29 Sep 2023 15:07:26 +0000 Subject: [PATCH] Revisions: slash meta values for autosave (preview) revisions. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Correct an issue where meta values containing characters like quote `”` could not be previewed on published posts. The function `update_metadata` expects data to be slashed. Also, add a test to confirm that storing JSON data which requires slashing in autosave meta works as expected, and improve naming for a data provider added in [56714]. Follow up to [56714]. Props mukesh27, spacedmonkey. Fixes #20564. Built from https://develop.svn.wordpress.org/trunk@56745 git-svn-id: http://core.svn.wordpress.org/trunk@56257 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- .../rest-api/endpoints/class-wp-rest-autosaves-controller.php | 2 +- wp-includes/version.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php b/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php index cbc3dc4c90..d14119133a 100644 --- a/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php +++ b/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php @@ -421,7 +421,7 @@ class WP_REST_Autosaves_Controller extends WP_REST_Revisions_Controller { if ( ! empty( $meta ) ) { foreach ( $revisioned_meta_keys as $meta_key ) { if ( isset( $meta[ $meta_key ] ) ) { - update_metadata( 'post', $revision_id, $meta_key, $meta[ $meta_key ] ); + update_metadata( 'post', $revision_id, $meta_key, wp_slash( $meta[ $meta_key ] ) ); } } } diff --git a/wp-includes/version.php b/wp-includes/version.php index 1a9cff07a7..e1f1e8a387 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.4-beta1-56744'; +$wp_version = '6.4-beta1-56745'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.