IntenseWebs/WordPress
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

REST API: Skip processing fields which are not present in the selected context.

Browse Source 
In `WP_REST_Controller::get_fields_for_response()`, exclude fields which are not registered to appear in the request's context.

In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit.

Props dlh.
Fixes #45605.

Built from https://develop.svn.wordpress.org/trunk@45706


git-svn-id: http://core.svn.wordpress.org/trunk@45517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
K. Adam White 2019-07-31 20:21:56 +00:00
parent d296736b75
commit 5f9ba92af4
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
wp-includes/rest-api/endpoints/class-wp-rest-controller.php
View File

@ -517,18 +517,30 @@ abstract class WP_REST_Controller {
* @return array Fields to be included in the response. * @return array Fields to be included in the response.
*/ */
public function get_fields_for_response( $request ) { public function get_fields_for_response( $request ) {
$schema = $this->get_item_schema(); $schema = $this->get_item_schema();
$fields = isset( $schema['properties'] ) ? array_keys( $schema['properties'] ) : array(); $properties = isset( $schema['properties'] ) ? $schema['properties'] : array();
$additional_fields = $this->get_additional_fields(); $additional_fields = $this->get_additional_fields();
foreach ( $additional_fields as $field_name => $field_options ) { foreach ( $additional_fields as $field_name => $field_options ) {
// For back-compat, include any field with an empty schema // For back-compat, include any field with an empty schema
// because it won't be present in $this->get_item_schema(). // because it won't be present in $this->get_item_schema().
if ( is_null( $field_options['schema'] ) ) { if ( is_null( $field_options['schema'] ) ) {
$fields[] = $field_name; $properties[ $field_name ] = $field_options;
} }
} }
// Exclude fields that specify a different context than the request context.
$context = $request['context'];
if ( $context ) {
foreach ( $properties as $name => $options ) {
if ( ! empty( $options['context'] ) && ! in_array( $context, $options['context'], true ) ) {
unset( $properties[ $name ] );
}
}
}
$fields = array_keys( $properties );
if ( ! isset( $request['_fields'] ) ) { if ( ! isset( $request['_fields'] ) ) {
return $fields; return $fields;
} }

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.3-alpha-45705'; $wp_version = '5.3-alpha-45706';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.