From 70c8bd23332a8054abce1dee695186642917689e Mon Sep 17 00:00:00 2001 From: Felix Arntz Date: Tue, 30 Jun 2020 20:34:06 +0000 Subject: [PATCH] Media: Only add `loading` attribute to `img` tags using double quotes. Props azaozz. Fixes #50367. Built from https://develop.svn.wordpress.org/trunk@48239 git-svn-id: http://core.svn.wordpress.org/trunk@48008 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/media.php | 4 ++-- wp-includes/version.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/wp-includes/media.php b/wp-includes/media.php index f9b41311c2..0dc67f7b86 100644 --- a/wp-includes/media.php +++ b/wp-includes/media.php @@ -1588,7 +1588,7 @@ function wp_image_add_srcset_and_sizes( $image, $image_meta, $attachment_id ) { $attr .= sprintf( ' sizes="%s"', esc_attr( $sizes ) ); } - // Add extra attributes to the image markup. + // Add the srcset and sizes attributes to the image markup. return preg_replace( '/]+?)[\/ ]*>/', '', $image ); } @@ -1737,7 +1737,7 @@ function wp_img_tag_add_loading_attr( $image, $context ) { } // Images should have source and dimension attributes for the `loading` attribute to be added. - if ( false === strpos( $image, ' src=' ) || false === strpos( $image, ' width=' ) || false === strpos( $image, ' height=' ) ) { + if ( false === strpos( $image, ' src="' ) || false === strpos( $image, ' width="' ) || false === strpos( $image, ' height="' ) ) { return $image; } diff --git a/wp-includes/version.php b/wp-includes/version.php index 3e6e38cb39..440d58c964 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -13,7 +13,7 @@ * * @global string $wp_version */ -$wp_version = '5.5-alpha-48238'; +$wp_version = '5.5-alpha-48239'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.