IntenseWebs/WordPress
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

REST API: Short-circuit comment controller permissions check if commented-upon post type does not exist.

Browse Source 
Props imani3011, dragosh635, subrataemfluence, timothyblynjacobs.
Fixes #42238.


Built from https://develop.svn.wordpress.org/trunk@47036


git-svn-id: http://core.svn.wordpress.org/trunk@46836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
K. Adam White 2020-01-03 18:44:03 +00:00
parent 355c05ea71
commit 7660fcda61
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php
View File

@ -1592,7 +1592,13 @@ class WP_REST_Comments_Controller extends WP_REST_Controller {
* @return bool Whether post can be read. * @return bool Whether post can be read.
*/ */
protected function check_read_post_permission( $post, $request ) { protected function check_read_post_permission( $post, $request ) {
$post_type = get_post_type_object( $post->post_type ); $post_type = get_post_type_object( $post->post_type );
// Return false if custom post type doesn't exist
if ( ! $post_type ) {
return false;
}
$posts_controller = $post_type->get_rest_controller(); $posts_controller = $post_type->get_rest_controller();
// Ensure the posts controller is specifically a WP_REST_Posts_Controller instance // Ensure the posts controller is specifically a WP_REST_Posts_Controller instance

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.4-alpha-47035'; $wp_version = '5.4-alpha-47036';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.