From 76f482de43b8e27ad7461b33ad7b034d441ecabb Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Sat, 3 Aug 2019 03:47:54 +0000 Subject: [PATCH] Posts, Post Types: Check the result of `wp_update_post()` in `wp_trash_post()` and `wp_untrash_post()`. Props abhijitrakas, manzoorwani.jk, siliconforks. Fixes #47773. Built from https://develop.svn.wordpress.org/trunk@45724 git-svn-id: http://core.svn.wordpress.org/trunk@45535 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/post.php | 12 ++++++++++-- wp-includes/version.php | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/wp-includes/post.php b/wp-includes/post.php index fea5c0e7f9..375fce3caa 100644 --- a/wp-includes/post.php +++ b/wp-includes/post.php @@ -3059,13 +3059,17 @@ function wp_trash_post( $post_id = 0 ) { add_post_meta( $post_id, '_wp_trash_meta_status', $post->post_status ); add_post_meta( $post_id, '_wp_trash_meta_time', time() ); - wp_update_post( + $post_updated = wp_update_post( array( 'ID' => $post_id, 'post_status' => 'trash', ) ); + if ( ! $post_updated ) { + return false; + } + wp_trash_post_comments( $post_id ); /** @@ -3126,13 +3130,17 @@ function wp_untrash_post( $post_id = 0 ) { delete_post_meta( $post_id, '_wp_trash_meta_status' ); delete_post_meta( $post_id, '_wp_trash_meta_time' ); - wp_update_post( + $post_updated = wp_update_post( array( 'ID' => $post_id, 'post_status' => $post_status, ) ); + if ( ! $post_updated ) { + return false; + } + wp_untrash_post_comments( $post_id ); /** diff --git a/wp-includes/version.php b/wp-includes/version.php index 2bf3164ae7..8132d61a41 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -13,7 +13,7 @@ * * @global string $wp_version */ -$wp_version = '5.3-alpha-45723'; +$wp_version = '5.3-alpha-45724'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.