IntenseWebs/boringproxy
3
0
Fork 0
mirror of https://github.com/boringproxy/boringproxy.git synced 2025-02-25 18:55:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug when creating client tokens

Browse Source 
It was using the user that made the request as the user to get
the list of clients from, which meant for example if an admin made
the request, you were limited to the names of clients that the
admin also used.
This commit is contained in:
Anders Pitman 2022-03-09 12:19:44 -07:00
parent c583e1409b
commit ebf114e182
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
api.go
View File

@ -449,28 +449,36 @@ func (a *Api) DeleteTunnel(tokenData TokenData, params url.Values) error {
func (a *Api) CreateToken(tokenData TokenData, params url.Values) (string, error) { func (a *Api) CreateToken(tokenData TokenData, params url.Values) (string, error) {
owner := params.Get("owner") ownerId := params.Get("owner")
if owner == "" { if ownerId == "" {
return "", errors.New("Invalid owner paramater") return "", errors.New("Invalid owner paramater")
} }
user, _ := a.db.GetUser(tokenData.Owner) user, _ := a.db.GetUser(tokenData.Owner)
if tokenData.Owner != owner && !user.IsAdmin { if tokenData.Owner != ownerId && !user.IsAdmin {
return "", errors.New("Unauthorized") return "", errors.New("Unauthorized")
} }
var owner User
if tokenData.Owner == ownerId {
owner = user
} else {
owner, _ = a.db.GetUser(ownerId)
}
client := params.Get("client") client := params.Get("client")
if client != "any" { if client != "any" {
if _, exists := user.Clients[client]; !exists { if _, exists := owner.Clients[client]; !exists {
return "", errors.New(fmt.Sprintf("Client %s does not exist for user %s", client, owner)) return "", errors.New(fmt.Sprintf("Client %s does not exist for user %s", client, ownerId))
} }
} else { } else {
client = "" client = ""
} }
token, err := a.db.AddToken(owner, client) token, err := a.db.AddToken(ownerId, client)
if err != nil { if err != nil {
return "", errors.New("Failed to create token") return "", errors.New("Failed to create token")
} }