2013-02-05 13:16:51 -06:00
require 'spec_helper'
require 'pretty_text'
describe PrettyText do
2013-02-25 10:42:20 -06:00
describe " Cooking " do
2013-02-05 13:16:51 -06:00
2013-08-13 15:08:29 -05:00
describe " with avatar " do
2013-02-05 13:16:51 -06:00
2013-08-13 15:08:29 -05:00
before ( :each ) do
eviltrout = User . new
eviltrout . stubs ( :avatar_template ) . returns ( " http://test.localhost/uploads/default/avatars/42d/57c/46ce7ee487/{size}.png " )
2014-05-06 08:41:59 -05:00
User . expects ( :find_by ) . with ( username_lower : " eviltrout " ) . returns ( eviltrout )
2013-08-13 15:08:29 -05:00
end
2013-02-05 13:16:51 -06:00
2013-08-13 15:08:29 -05:00
it " produces a quote even with new lines in it " do
2014-09-18 22:39:18 -05:00
PrettyText . cook ( " [quote= \" EvilTrout, post:123, topic:456, full:true \" ]ddd \n [/quote] " ) . should match_html " <aside class= \" quote \" data-post= \" 123 \" data-topic= \" 456 \" data-full= \" true \" ><div class= \" title \" > \n <div class= \" quote-controls \" ></div> \n <img width= \" 20 \" height= \" 20 \" src= \" http://test.localhost/uploads/default/avatars/42d/57c/46ce7ee487/40.png \" class= \" avatar \" >EvilTrout:</div> \n <blockquote><p>ddd</p></blockquote></aside> "
2013-08-13 15:08:29 -05:00
end
2013-02-05 13:16:51 -06:00
2013-08-13 15:08:29 -05:00
it " should produce a quote " do
2014-09-18 22:39:18 -05:00
PrettyText . cook ( " [quote= \" EvilTrout, post:123, topic:456, full:true \" ]ddd[/quote] " ) . should match_html " <aside class= \" quote \" data-post= \" 123 \" data-topic= \" 456 \" data-full= \" true \" ><div class= \" title \" > \n <div class= \" quote-controls \" ></div> \n <img width= \" 20 \" height= \" 20 \" src= \" http://test.localhost/uploads/default/avatars/42d/57c/46ce7ee487/40.png \" class= \" avatar \" >EvilTrout:</div> \n <blockquote><p>ddd</p></blockquote></aside> "
2013-08-13 15:08:29 -05:00
end
it " trims spaces on quote params " do
2014-09-18 22:39:18 -05:00
PrettyText . cook ( " [quote= \" EvilTrout, post:555, topic: 666 \" ]ddd[/quote] " ) . should match_html " <aside class= \" quote \" data-post= \" 555 \" data-topic= \" 666 \" ><div class= \" title \" > \n <div class= \" quote-controls \" ></div> \n <img width= \" 20 \" height= \" 20 \" src= \" http://test.localhost/uploads/default/avatars/42d/57c/46ce7ee487/40.png \" class= \" avatar \" >EvilTrout:</div> \n <blockquote><p>ddd</p></blockquote></aside> "
2013-08-13 15:08:29 -05:00
end
end
2013-02-05 13:16:51 -06:00
2013-02-25 10:42:20 -06:00
it " should handle 3 mentions in a row " do
2013-04-09 22:27:33 -05:00
PrettyText . cook ( '@hello @hello @hello' ) . should match_html " <p><span class= \" mention \" >@hello</span> <span class= \" mention \" >@hello</span> <span class= \" mention \" >@hello</span></p> "
2013-02-05 13:16:51 -06:00
end
it " should sanitize the html " do
2013-10-18 14:20:27 -05:00
PrettyText . cook ( " <script>alert(42)</script> " ) . should match_html " <p></p> "
2013-02-05 13:16:51 -06:00
end
it 'should allow for @mentions to have punctuation' do
2013-04-09 22:27:33 -05:00
PrettyText . cook ( " hello @bob's @bob,@bob; @bob \" " ) . should
match_html " <p>hello <span class= \" mention \" >@bob</span>'s <span class= \" mention \" >@bob</span>,<span class= \" mention \" >@bob</span>; <span class= \" mention \" >@bob</span> \" </p> "
2013-02-05 13:16:51 -06:00
end
2014-10-02 21:37:07 -05:00
# see: https://github.com/sparklemotion/nokogiri/issues/1173
pending 'allows html entities correctly' do
PrettyText . cook ( " ℵ£& # 162; " ) . should == " <p>ℵ£& # 162;</p> "
end
2013-02-05 13:16:51 -06:00
end
2013-02-25 10:42:20 -06:00
2013-02-10 18:43:07 -06:00
describe " rel nofollow " do
2013-02-25 10:42:20 -06:00
before do
2013-02-10 18:43:07 -06:00
SiteSetting . stubs ( :add_rel_nofollow_to_user_content ) . returns ( true )
2014-03-29 18:50:44 -05:00
SiteSetting . stubs ( :exclude_rel_nofollow_domains ) . returns ( " foo.com|bar.com " )
2013-02-10 18:43:07 -06:00
end
2013-02-25 10:42:20 -06:00
it " should inject nofollow in all user provided links " do
2013-02-10 18:43:07 -06:00
PrettyText . cook ( '<a href="http://cnn.com">cnn</a>' ) . should =~ / nofollow /
end
2013-02-25 10:42:20 -06:00
it " should not inject nofollow in all local links " do
2014-09-25 10:44:48 -05:00
( PrettyText . cook ( " <a href=' #{ Discourse . base_url } /test.html'>cnn</a> " ) !~ / nofollow / ) . should == true
2013-02-10 18:43:07 -06:00
end
2013-02-25 10:42:20 -06:00
it " should not inject nofollow in all subdomain links " do
2014-09-25 10:44:48 -05:00
( PrettyText . cook ( " <a href=' #{ Discourse . base_url . sub ( 'http://' , 'http://bla.' ) } /test.html'>cnn</a> " ) !~ / nofollow / ) . should == true
2013-02-10 18:43:07 -06:00
end
2013-02-11 01:58:19 -06:00
it " should not inject nofollow for foo.com " do
2014-09-25 10:44:48 -05:00
( PrettyText . cook ( " <a href='http://foo.com/test.html'>cnn</a> " ) !~ / nofollow / ) . should == true
2013-02-11 01:58:19 -06:00
end
2013-02-25 10:42:20 -06:00
2013-02-11 01:58:19 -06:00
it " should not inject nofollow for bar.foo.com " do
2014-09-25 10:44:48 -05:00
( PrettyText . cook ( " <a href='http://bar.foo.com/test.html'>cnn</a> " ) !~ / nofollow / ) . should == true
2013-02-11 01:58:19 -06:00
end
2014-01-15 10:34:17 -06:00
it " should not inject nofollow if omit_nofollow option is given " do
2014-09-25 10:44:48 -05:00
( PrettyText . cook ( '<a href="http://cnn.com">cnn</a>' , omit_nofollow : true ) !~ / nofollow / ) . should == true
2014-01-15 10:34:17 -06:00
end
2013-02-10 18:43:07 -06:00
end
2013-02-05 13:16:51 -06:00
2013-02-25 10:42:20 -06:00
describe " Excerpt " do
2013-04-29 22:25:55 -05:00
2014-07-24 21:15:43 -05:00
it " sanitizes attempts to inject invalid attributes " do
spinner = " <a href= \" http://thedailywtf.com/ \" data-bbcode= \" ' class='fa fa-spin \" >WTF</a> "
PrettyText . excerpt ( spinner , 20 ) . should match_html spinner
spinner = %q{ <a href="http://thedailywtf.com/" title="' class="fa fa-spin"><img src='http://thedailywtf.com/Resources/Images/Primary/logo.gif"></a> }
PrettyText . excerpt ( spinner , 20 ) . should match_html spinner
end
2013-06-05 17:54:46 -05:00
context " images " do
2014-07-17 00:40:19 -05:00
2013-06-05 17:54:46 -05:00
it " should dump images " do
PrettyText . excerpt ( " <img src='http://cnn.com/a.gif'> " , 100 ) . should == " [image] "
end
2013-04-29 22:25:55 -05:00
2013-06-05 17:54:46 -05:00
it " should keep alt tags " do
PrettyText . excerpt ( " <img src='http://cnn.com/a.gif' alt='car' title='my big car'> " , 100 ) . should == " [car] "
end
it " should keep title tags " do
PrettyText . excerpt ( " <img src='http://cnn.com/a.gif' title='car'> " , 100 ) . should == " [car] "
end
it " should convert images to markdown if the option is set " do
PrettyText . excerpt ( " <img src='http://cnn.com/a.gif' title='car'> " , 100 , markdown_images : true ) . should == " ![car](http://cnn.com/a.gif) "
end
2013-02-05 13:16:51 -06:00
2014-02-20 02:48:30 -06:00
it " should keep spoilers " do
2014-07-24 21:15:43 -05:00
PrettyText . excerpt ( " <div class='spoiler'><img src='http://cnn.com/a.gif'></div> " , 100 ) . should match_html " <span class='spoiler'>[image]</span> "
PrettyText . excerpt ( " <span class='spoiler'>spoiler</div> " , 100 ) . should match_html " <span class='spoiler'>spoiler</span> "
2014-02-20 02:48:30 -06:00
end
2013-02-05 13:16:51 -06:00
end
2013-02-25 10:42:20 -06:00
2013-06-05 17:54:46 -05:00
it " should have an option to strip links " do
PrettyText . excerpt ( " <a href='http://cnn.com'>cnn</a> " , 100 , strip_links : true ) . should == " cnn "
2013-02-05 13:16:51 -06:00
end
2013-02-25 10:42:20 -06:00
2013-06-05 17:54:46 -05:00
it " should preserve links " do
2014-07-24 21:15:43 -05:00
PrettyText . excerpt ( " <a href='http://cnn.com'>cnn</a> " , 100 ) . should match_html " <a href='http://cnn.com'>cnn</a> "
2013-02-05 13:16:51 -06:00
end
2013-02-25 10:42:20 -06:00
it " should deal with special keys properly " do
2013-02-05 13:16:51 -06:00
PrettyText . excerpt ( " <pre><b></pre> " , 100 ) . should == " "
end
2013-02-25 10:42:20 -06:00
it " should truncate stuff properly " do
2013-02-05 13:16:51 -06:00
PrettyText . excerpt ( " hello world " , 5 ) . should == " hello… "
2013-05-10 05:28:17 -05:00
PrettyText . excerpt ( " <p>hello</p><p>world</p> " , 6 ) . should == " hello w… "
2013-02-05 13:16:51 -06:00
end
2013-02-25 10:42:20 -06:00
it " should insert a space between to Ps " do
2013-06-04 11:05:36 -05:00
PrettyText . excerpt ( " <p>a</p><p>b</p> " , 5 ) . should == " a b "
2013-02-05 13:16:51 -06:00
end
2013-02-25 10:42:20 -06:00
it " should strip quotes " do
2013-02-05 13:16:51 -06:00
PrettyText . excerpt ( " <aside class='quote'><p>a</p><p>b</p></aside>boom " , 5 ) . should == " boom "
end
2013-02-25 10:42:20 -06:00
it " should not count the surrounds of a link " do
2014-07-24 21:15:43 -05:00
PrettyText . excerpt ( " <a href='http://cnn.com'>cnn</a> " , 3 ) . should match_html " <a href='http://cnn.com'>cnn</a> "
2013-02-05 13:16:51 -06:00
end
2013-06-03 15:12:24 -05:00
it " uses an ellipsis instead of html entities if provided with the option " do
2014-07-24 21:15:43 -05:00
PrettyText . excerpt ( " <a href='http://cnn.com'>cnn</a> " , 2 , text_entities : true ) . should match_html " <a href='http://cnn.com'>cn...</a> "
2013-06-03 15:12:24 -05:00
end
2013-02-25 10:42:20 -06:00
it " should truncate links " do
2014-07-24 21:15:43 -05:00
PrettyText . excerpt ( " <a href='http://cnn.com'>cnn</a> " , 2 ) . should match_html " <a href='http://cnn.com'>cn…</a> "
2013-02-05 13:16:51 -06:00
end
2014-05-20 16:20:52 -05:00
it " doesn't extract empty quotes as links " do
PrettyText . extract_links ( " <aside class='quote'>not a linked quote</aside> \n " ) . to_a . should be_empty
end
2014-07-10 23:17:01 -05:00
def extract_urls ( text )
PrettyText . extract_links ( text ) . map ( & :url ) . to_a
end
2013-02-25 10:42:20 -06:00
it " should be able to extract links " do
2014-07-10 23:17:01 -05:00
extract_urls ( " <a href='http://cnn.com'>http://bla.com</a> " ) . should == [ " http://cnn.com " ]
2013-02-05 13:16:51 -06:00
end
2013-02-13 14:22:04 -06:00
it " should extract links to topics " do
2014-07-10 23:17:01 -05:00
extract_urls ( " <aside class= \" quote \" data-topic= \" 321 \" >aside</aside> " ) . should == [ " /t/topic/321 " ]
2013-02-13 14:22:04 -06:00
end
it " should extract links to posts " do
2014-07-10 23:17:01 -05:00
extract_urls ( " <aside class= \" quote \" data-topic= \" 1234 \" data-post= \" 4567 \" >aside</aside> " ) . should == [ " /t/topic/1234/4567 " ]
2013-02-13 14:22:04 -06:00
end
2013-06-05 13:53:07 -05:00
it " should not extract links inside quotes " do
2014-07-10 23:17:01 -05:00
links = PrettyText . extract_links ( "
2013-06-05 13:53:07 -05:00
< a href = 'http://body_only.com' > http : / /use less1 . com < / a>
< aside class = \ " quote \" data-topic= \" 1234 \" >
< a href = 'http://body_and_quote.com' > http : / /use less3 . com < / a>
< a href = 'http://quote_only.com' > http : / /use less4 . com < / a>
< / aside>
< a href = 'http://body_and_quote.com' > http : / /use less2 . com < / a>
2014-07-10 23:17:01 -05:00
" )
links . map { | l | [ l . url , l . is_quote ] } . to_a . sort . should ==
[ [ " http://body_only.com " , false ] ,
[ " http://body_and_quote.com " , false ] ,
[ " /t/topic/1234 " , true ]
] . sort
2013-06-05 13:53:07 -05:00
end
2013-02-25 10:42:20 -06:00
it " should not preserve tags in code blocks " do
2013-02-05 13:16:51 -06:00
PrettyText . excerpt ( " <pre><code class='handlebars'><h3>Hours</h3></code></pre> " , 100 ) . should == " <h3>Hours</h3> "
end
it " should handle nil " do
PrettyText . excerpt ( nil , 100 ) . should == ''
end
2013-05-10 05:28:17 -05:00
2014-09-03 02:12:56 -05:00
it " handles span excerpt at the beginning of a post " do
2014-07-17 06:32:17 -05:00
PrettyText . excerpt ( " <span class='excerpt'>hi</span> test " , 100 ) . should == 'hi'
post = Fabricate ( :post , raw : " <span class='excerpt'>hi</span> test " )
post . excerpt . should == " hi "
end
2014-09-04 00:03:12 -05:00
it " ignores max excerpt length if a span excerpt is specified " do
two_hundred = " 123456789 " * 20 + " . "
text = two_hundred + " <span class='excerpt'> #{ two_hundred } </span> " + two_hundred
PrettyText . excerpt ( text , 100 ) . should == two_hundred
2014-09-03 02:12:56 -05:00
post = Fabricate ( :post , raw : text )
2014-09-04 00:03:12 -05:00
post . excerpt . should == two_hundred
2014-09-03 02:12:56 -05:00
end
2013-02-05 13:16:51 -06:00
end
2013-06-05 14:28:10 -05:00
describe " strip links " do
it " returns blank for blank input " do
expect ( PrettyText . strip_links ( " " ) ) . to be_blank
end
it " does nothing to a string without links " do
expect ( PrettyText . strip_links ( " I'm the <b>batman</b> " ) ) . to eq ( " I'm the <b>batman</b> " )
end
it " strips links but leaves the text content " do
expect ( PrettyText . strip_links ( " I'm the linked <a href='http://en.wikipedia.org/wiki/Batman'>batman</a> " ) ) . to eq ( " I'm the linked batman " )
end
2014-09-17 11:08:00 -05:00
it " escapes the text content " do
expect ( PrettyText . strip_links ( " I'm the linked <a href='http://en.wikipedia.org/wiki/Batman'><batman></a> " ) ) . to eq ( " I'm the linked <batman> " )
end
2013-06-05 14:28:10 -05:00
end
2013-02-10 18:43:07 -06:00
2013-11-28 14:57:21 -06:00
describe " make_all_links_absolute " do
let ( :base_url ) { " http://baseurl.net " }
2014-04-17 11:32:51 -05:00
def make_abs_string ( html )
doc = Nokogiri :: HTML . fragment ( html )
described_class . make_all_links_absolute ( doc )
doc . to_html
end
2013-11-28 14:57:21 -06:00
before do
Discourse . stubs ( :base_url ) . returns ( base_url )
end
it " adds base url to relative links " do
html = " <p><a class= \" mention \" href= \" /users/wiseguy \" >@wiseguy</a>, <a class= \" mention \" href= \" /users/trollol \" >@trollol</a> what do you guys think? </p> "
2014-04-17 11:32:51 -05:00
output = make_abs_string ( html )
2013-11-28 14:57:21 -06:00
output . should == " <p><a class= \" mention \" href= \" #{ base_url } /users/wiseguy \" >@wiseguy</a>, <a class= \" mention \" href= \" #{ base_url } /users/trollol \" >@trollol</a> what do you guys think? </p> "
end
it " doesn't change external absolute links " do
html = " <p>Check out <a href= \" http://mywebsite.com/users/boss \" >this guy</a>.</p> "
2014-04-17 11:32:51 -05:00
make_abs_string ( html ) . should == html
2013-11-28 14:57:21 -06:00
end
it " doesn't change internal absolute links " do
html = " <p>Check out <a href= \" #{ base_url } /users/boss \" >this guy</a>.</p> "
2014-04-17 11:32:51 -05:00
make_abs_string ( html ) . should == html
2013-11-28 14:57:21 -06:00
end
it " can tolerate invalid URLs " do
html = " <p>Check out <a href= \" not a real url \" >this guy</a>.</p> "
2014-04-17 11:32:51 -05:00
expect { make_abs_string ( html ) } . to_not raise_error
end
end
describe " strip_image_wrapping " do
def strip_image_wrapping ( html )
doc = Nokogiri :: HTML . fragment ( html )
described_class . strip_image_wrapping ( doc )
doc . to_html
end
it " doesn't change HTML when there's no wrapped image " do
html = " <img src= \" wat.png \" > "
strip_image_wrapping ( html ) . should == html
end
let ( :wrapped_image ) { " <div class= \" lightbox-wrapper \" ><a href= \" //localhost:3000/uploads/default/4399/33691397e78b4d75.png \" class= \" lightbox \" title= \" Screen Shot 2014-04-14 at 9.47.10 PM.png \" ><img src= \" //localhost:3000/uploads/default/_optimized/bd9/b20/bbbcd6a0c0_655x500.png \" width= \" 655 \" height= \" 500 \" ><div class= \" meta \" > \n <span class= \" filename \" >Screen Shot 2014-04-14 at 9.47.10 PM.png</span><span class= \" informations \" >966x737 1.47 MB</span><span class= \" expand \" ></span> \n </div></a></div> " }
it " strips the metadata " do
strip_image_wrapping ( wrapped_image ) . should == " <div class= \" lightbox-wrapper \" ><a href= \" //localhost:3000/uploads/default/4399/33691397e78b4d75.png \" class= \" lightbox \" title= \" Screen Shot 2014-04-14 at 9.47.10 PM.png \" ><img src= \" //localhost:3000/uploads/default/_optimized/bd9/b20/bbbcd6a0c0_655x500.png \" width= \" 655 \" height= \" 500 \" ></a></div> "
2013-11-28 14:57:21 -06:00
end
end
2014-07-30 02:09:55 -05:00
describe 'format_for_email' do
it 'does not crash' do
PrettyText . format_for_email ( '<a href="mailto:michael.brown@discourse.org?subject=Your%20post%20at%20http://try.discourse.org/t/discussion-happens-so-much/127/1000?u=supermathie">test</a>' )
end
end
2013-02-05 13:16:51 -06:00
end